Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ord1 instances for Binding, NExprF, and NKeyName #715

Merged
merged 1 commit into from
Sep 13, 2020

Conversation

sjakobi
Copy link
Member

@sjakobi sjakobi commented Sep 12, 2020

With data-fix 0.3, these instances are required so an
Ord instance for NExpr can be inferred.

With data-fix 0.3, these instances are required so an
Ord instance for NExpr can be inferred.
@sjakobi
Copy link
Member Author

sjakobi commented Sep 12, 2020

I discovered the missing Ord instance for NExpr while updating dhall-nixpkgs.

The Ord1 instance for NKeyName is modeled after the Eq1 instance.

@Anton-Latukha Once this is merged, would you mind making another release? In addition to dhall-nixpkgs there might be other packages for which hnix-0.10.0 is currently unusable due to the missing instance.

@Anton-Latukha
Copy link
Collaborator

Great.

Then there is need to make quick 0.11.0 then.

@Anton-Latukha Anton-Latukha merged commit 775be0d into master Sep 13, 2020
@Anton-Latukha Anton-Latukha deleted the sjakobi/ord1 branch September 13, 2020 09:47
@Anton-Latukha
Copy link
Collaborator

Why did you mention that it can be inferred, but decided not to infer it? Is there is a reason, or you see a lack of.

NExpr Ord and so the Eq - seems of be in the list of the the most importance to have, it is interesting that we not seen that they were not in place.

@sjakobi
Copy link
Member Author

sjakobi commented Sep 13, 2020

Then there is need to make quick 0.11.0 then.

What's the reason for the major version bump?

@sjakobi
Copy link
Member Author

sjakobi commented Sep 13, 2020

Why did you mention that it can be inferred, but decided not to infer it? Is there is a reason, or you see a lack of.

NExpr is just Fix NExprF.

In v0.3.0, data-fix replaced the instance

Ord (f (Fix f)) => Ord (Fix f)

with

Ord1 f => Ord (Fix f)

@Anton-Latukha
Copy link
Collaborator

Ok, yes.

Ok, yes I also returned, looked that NExpr is a type synonym.

@Anton-Latukha
Copy link
Collaborator

Then there is need to make quick 0.11.0 then.

What's the reason for the major version bump?

Well, the API change. I keep forgetting on interface expansion is the increase needed.

PVP way is unclear in this case, it says that version "may" stay the same. May meaning the choice decision is truly optional.

Well, on the second thought it indeed may be left a minor number.

It is probably good to remember that expansion of the API is optional and minor if there is no breakage of old deps, and major if there may be some sort of breakage because of the expansion.

@sjakobi
Copy link
Member Author

sjakobi commented Sep 13, 2020

Then there is need to make quick 0.11.0 then.

What's the reason for the major version bump?

Well, the API change. I keep forgetting on interface expansion is the increase needed.

PVP way is unclear in this case, it says that version "may" stay the same. May meaning the choice decision is truly optional.

It's better to stick with a minor bump in this case. Otherwise people would need to update the bounds in their cabal files again.

@Anton-Latukha
Copy link
Collaborator

Yes.

@sjakobi
Copy link
Member Author

sjakobi commented Sep 13, 2020

Thanks for the quick release! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants