Use pre-whitespace position for source end locations #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layus
approved these changes
Oct 27, 2020
expipiplus1
added a commit
to expipiplus1/hnix
that referenced
this pull request
Oct 29, 2020
it is not generally appropriate to have higher-order parsers operate on annotated locations as they are liable to perform changes to the parser which are not captured in the annotation. See haskell-nix#739 and haskell-nix#744 for examples.
expipiplus1
added a commit
to expipiplus1/hnix
that referenced
this pull request
Oct 29, 2020
it is not generally appropriate to have higher-order parsers operate on annotated locations as they are liable to perform changes to the parser which are not captured in the annotation. See haskell-nix#739 and haskell-nix#744 for examples.
|
Lol, can't believe it took me 4 years to come up with this. #35 (comment) (I think back then it might have been hampered by using trifecta instead of megaparsec or something) |
|
Thanks @layus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #743
I have not tested this extensively, so please consider this a WIPI have tested this a little bit and it seems to work