More refactors #935
Merged
More refactors #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just to match constructor definition order.
As after reordering it can be seen - they match on all constructors.
As there is only 1 constructor to Ann & as everything is guarded by type code - there is only 1 possible pattern under that type - so it is complete. As a result GHC now sees that buttoms are superflous.
Some improvement ideas. Grew to not like to put such in reports, since they get lost there and one can implement them while at hand in the topic. (probably would do this during breakage writing phase).
It is not fully finished reorganization, but better then nothing. There were several minor optimizations made to the code.
That is my understanding, it can be wrong (but hey, there were no better there)!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once started organizing, it is hard to stop.
Somehow forgot to
bytestring 0.11, thought we updated to it.During it found & made a couple of small optimizations here and there.
And left notes for future to introduce breaking changes to provide more optimization. Some
NExprFarguments need reordering (for performance) & synonymizing (for readability) (it is a close topic to the #377).