Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expr: Types: changes #978

Merged
merged 12 commits into from
Jul 21, 2021
Merged

Expr: Types: changes #978

merged 12 commits into from
Jul 21, 2021

Conversation

Anton-Latukha
Copy link
Collaborator

No description provided.

@Anton-Latukha
Expr: Types: add newtype VariadicBool for ParamSets
984d1a2
@Anton-Latukha
Expr: Types: (newtype VariadicBool -> Variadic(Closed|Variadic)
a1267b6 
In this case the coerce boundary seems innapropriate. Lifting to newtype was
done for refactoring convinience.
@Anton-Latukha
Expr: Types: Params(ParamSet): order arguments
da480ab 
Naming of sets is rarely used & function Nothing bytecode would be reused.

After that Nixpkgs mostly uses closed sets, so function Nothing Nothing branch
of the bytecode would be reused.
@Anton-Latukha
Expr: Shorthands: add mk{,Named,Variadic,General}ParamSet, depr mkPar…
4ea629c 
…amset
@Anton-Latukha
Expr: Types: fx docs
543b0a4
@Anton-Latukha
Scope: upd push*Scope* (AttrSet VarName a -> Scope a)
39e67b5
@Anton-Latukha
Type.Assumption: Assumption: rm newtype getter
80c763e
@Anton-Latukha
Builtins: Prim: rm newtype accessor
38ac1fe
@Anton-Latukha
Type: Infer: InferState: rm newtype accessor
eefdcc4
@Anton-Latukha
Repl: m: qualify name for HashMap
dd33ecf
@Anton-Latukha
Convert: add fun inHask{,M,May}
f81830b
@Anton-Latukha Anton-Latukha marked this pull request as ready for review July 21, 2021 10:12
@Anton-Latukha
Expr: Types: Binding(Inherit): NKeyName -> VarName
a6d9f3e 
Thread: #377 (comment)

`inherit x y` in y` position always takes a variable name.

Nix allows `inherit x "y"`, but there is no use (in the wild real life use) for
it, it seems a misfeature and would be considered a quirk of the original type
system/implementation, until the use case of it would be clear (which is hard,
since there is a single use of it in Nixpkgs, which is mentioned in the thread).
@Anton-Latukha Anton-Latukha force-pushed the 2021-07-19-expr-types branch from 194cd19 to a6d9f3e Compare July 21, 2021 10:49
@Anton-Latukha Anton-Latukha merged commit dd2d300 into master Jul 21, 2021
@Anton-Latukha Anton-Latukha mentioned this pull request Jul 21, 2021
Closed
@Anton-Latukha Anton-Latukha deleted the 2021-07-19-expr-types branch July 21, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Anton-Latukha