Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in LumiGuide's updates #3

Open
DanBurton opened this issue Feb 20, 2019 · 1 comment
Open

Pull in LumiGuide's updates #3

DanBurton opened this issue Feb 20, 2019 · 1 comment

Comments

@DanBurton
Copy link
Collaborator

@DanBurton
Copy link
Collaborator Author

This was partially done in 5c69c3a

There's still some TODOs to review about this for various reasons.

nh2 added a commit to nh2/haskell-opencv that referenced this issue Sep 6, 2023
The main task here is to make `doc-images-opencv` work,
which is this package's way to generate nice documentation images
into the Haddocks, from code that's in the Haddocks.

For that, this commit:

* Deletes copy-pasted + modified module from `haskell-src-meta`,
  `Language.Haskell.Meta.Syntax.Translate`, since as per the commit mentioned in
  * bmillwood/haskell-src-meta#54
  * haskell-party/haskell-src-meta#3 (comment)
  * haskell-party/haskell-src-meta@5c69c3a
  the necessary `DataKinds` changes were merged upstream.
  The commit suggests it's in >= 0.8.3, so that's what's added in the `.cabal` file.

* Replaces all occurrences of `*` by `Type` from `Data.Kind` to fix
  all `-Wstar-is-type` warnings
  (see also https://ghc-proposals.readthedocs.io/en/latest/proposals/0143-remove-star-kind.html).
  This is necessary because the upstream `haskell-src-meta` above
  does not support `*` but does support `Type`; it would print:
      Language.Haskell.Meta.Syntax.Translate.toType: not implemented: TyStar ()
nh2 added a commit to nh2/haskell-opencv that referenced this issue Sep 6, 2023
The main task here is to make `doc-images-opencv` work,
which is this package's way to generate nice documentation images
into the Haddocks, from code that's in the Haddocks.

For that, this commit:

* Deletes copy-pasted + modified module from `haskell-src-meta`,
  `Language.Haskell.Meta.Syntax.Translate`, since as per the commit mentioned in
  * bmillwood/haskell-src-meta#54
  * haskell-party/haskell-src-meta#3 (comment)
  * haskell-party/haskell-src-meta@5c69c3a
  the necessary `DataKinds` changes were merged upstream.
  The commit suggests it's in >= 0.8.3, so that's what's added in the `.cabal` file.

* Replaces all occurrences of `*` by `Type` from `Data.Kind` to fix
  all `-Wstar-is-type` warnings
  (see also https://ghc-proposals.readthedocs.io/en/latest/proposals/0143-remove-star-kind.html).
  This is necessary because the upstream `haskell-src-meta` above
  does not support `*` but does support `Type`; it would print:
      Language.Haskell.Meta.Syntax.Translate.toType: not implemented: TyStar ()
nh2 added a commit to nh2/haskell-opencv that referenced this issue Sep 6, 2023
The main task here is to make `doc-images-opencv` work,
which is this package's way to generate nice documentation images
into the Haddocks, from code that's in the Haddocks.

For that, this commit:

* Deletes copy-pasted + modified module from `haskell-src-meta`,
  `Language.Haskell.Meta.Syntax.Translate`, since as per the commit mentioned in
  * bmillwood/haskell-src-meta#54
  * haskell-party/haskell-src-meta#3 (comment)
  * haskell-party/haskell-src-meta@5c69c3a
  the necessary `DataKinds` changes were merged upstream.
  The commit suggests it's in >= 0.8.3, so that's what's added in the `.cabal` file.

* Replaces all occurrences of `*` by `Type` from `Data.Kind` to fix
  all `-Wstar-is-type` warnings
  (see also https://ghc-proposals.readthedocs.io/en/latest/proposals/0143-remove-star-kind.html).
  This is necessary because the upstream `haskell-src-meta` above
  does not support `*` but does support `Type`; it would print:
      Language.Haskell.Meta.Syntax.Translate.toType: not implemented: TyStar ()
nh2 added a commit to nh2/haskell-opencv that referenced this issue Sep 7, 2023
The main task here is to make `doc-images-opencv` work,
which is this package's way to generate nice documentation images
into the Haddocks, from code that's in the Haddocks.

For that, this commit:

* Deletes copy-pasted + modified module from `haskell-src-meta`,
  `Language.Haskell.Meta.Syntax.Translate`, since as per the commit mentioned in
  * bmillwood/haskell-src-meta#54
  * haskell-party/haskell-src-meta#3 (comment)
  * haskell-party/haskell-src-meta@5c69c3a
  the necessary `DataKinds` changes were merged upstream.
  The commit suggests it's in >= 0.8.3, so that's what's added in the `.cabal` file.

* Replaces all occurrences of `*` by `Type` from `Data.Kind` to fix
  all `-Wstar-is-type` warnings
  (see also https://ghc-proposals.readthedocs.io/en/latest/proposals/0143-remove-star-kind.html).
  This is necessary because the upstream `haskell-src-meta` above
  does not support `*` but does support `Type`; it would print:
      Language.Haskell.Meta.Syntax.Translate.toType: not implemented: TyStar ()
nh2 added a commit to nh2/haskell-opencv that referenced this issue Sep 29, 2023
The main task here is to make `doc-images-opencv` work,
which is this package's way to generate nice documentation images
into the Haddocks, from code that's in the Haddocks.

For that, this commit:

* Deletes copy-pasted + modified module from `haskell-src-meta`,
  `Language.Haskell.Meta.Syntax.Translate`, since as per the commit mentioned in
  * bmillwood/haskell-src-meta#54
  * haskell-party/haskell-src-meta#3 (comment)
  * haskell-party/haskell-src-meta@5c69c3a
  the necessary `DataKinds` changes were merged upstream.
  The commit suggests it's in >= 0.8.3, so that's what's added in the `.cabal` file.

* Replaces all occurrences of `*` by `Type` from `Data.Kind` to fix
  all `-Wstar-is-type` warnings
  (see also https://ghc-proposals.readthedocs.io/en/latest/proposals/0143-remove-star-kind.html).
  This is necessary because the upstream `haskell-src-meta` above
  does not support `*` but does support `Type`; it would print:
      Language.Haskell.Meta.Syntax.Translate.toType: not implemented: TyStar ()
nh2 added a commit to nh2/haskell-opencv that referenced this issue Sep 29, 2023
The main task here is to make `doc-images-opencv` work,
which is this package's way to generate nice documentation images
into the Haddocks, from code that's in the Haddocks.

For that, this commit:

* Deletes copy-pasted + modified module from `haskell-src-meta`,
  `Language.Haskell.Meta.Syntax.Translate`, since as per the commit mentioned in
  * bmillwood/haskell-src-meta#54
  * haskell-party/haskell-src-meta#3 (comment)
  * haskell-party/haskell-src-meta@5c69c3a
  the necessary `DataKinds` changes were merged upstream.
  The commit suggests it's in >= 0.8.3, so that's what's added in the `.cabal` file.

* Replaces all occurrences of `*` by `Type` from `Data.Kind` to fix
  all `-Wstar-is-type` warnings
  (see also https://ghc-proposals.readthedocs.io/en/latest/proposals/0143-remove-star-kind.html).
  This is necessary because the upstream `haskell-src-meta` above
  does not support `*` but does support `Type`; it would print:
      Language.Haskell.Meta.Syntax.Translate.toType: not implemented: TyStar ()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant