Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added type synonym for error in mimeUnrender and ResultStream #1053

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jhmcstanton
Copy link

Just used one of the type names suggested in the issue, is that name still OK?

@tchoutri
Copy link
Contributor

Hi @jhmcstanton! Thank you very much for this PR. In concertation with @gdeest and @akhesaCaro, we have come to the conclusion that this type ought to be a newtype, so that we can better restrict the scope of possible values. As an aside, do you think that the entirety of Shakespear's work in Mandarin could be a valid BodyDecodingError? :)

Copy link
Contributor

@tchoutri tchoutri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be newtyped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants