Skip to content

Conversation

@ysangkok
Copy link
Contributor

@ysangkok ysangkok commented Feb 6, 2022

Tested using

cabal test --constraint='hashable>=1.4' --constraint='text>=2' --constraint='lens>=5.1' --allow-newer=servant-multipart:lens,servant-multipart:text,servant-pagination:text,io-streams:text,blaze-html:text,swagger2:text,servant-js:lens,servant-js:text all

on GHC 9.0.2.

Copy link
Contributor

@akhesaCaro akhesaCaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI agrees :p

Copy link
Contributor

@alpmestan alpmestan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We'll probably want to reflect these changes as revisions to the last releases of all the affected libraries as well.

@gdeest
Copy link
Contributor

gdeest commented Feb 7, 2022

LGTM. We'll probably want to reflect these changes as revisions to the last releases of all the affected libraries as well.

Agreed.

@gdeest gdeest merged commit cdd7c34 into haskell-servant:master Feb 7, 2022
@ysangkok
Copy link
Contributor Author

@alpmestan It seems like the revisions you refer to haven't actually been made. Do you know who I can ping to get them out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants