Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

Please, help us merge or integrate the HLint action #81

Closed
Anton-Latukha opened this issue Nov 4, 2021 · 3 comments
Closed

Please, help us merge or integrate the HLint action #81

Anton-Latukha opened this issue Nov 4, 2021 · 3 comments
Labels
re: hlint Concerning the hlint actions

Comments

@Anton-Latukha
Copy link
Collaborator

Anton-Latukha commented Nov 4, 2021 •
edited
Loading

In ndmitchell/hlint#1311 we found & Neil blessed the currently best HLint action that exists.

An important feature of it - it allows softly suggesting code improvements, & so allows to use HLint in the project while also preserving the ease of pleasantness in the code merge processes.

How we would adopt the usage of it.

Calling author into the thread: @rwe.
@hazelweakly
Copy link
Collaborator

How we would adopt the usage of it.

The long story short is that this repo was designed to be a "monorepo" of actions. So having a directory in the root called hlint that contains the hlint github action would be sufficient, and a PR that adds that would be accepted.

It shouldn't take too much modification to make https://github.com/rwe/actions-hlint-setup a directory in this repo if that's agreeable, and I can make @rwe a contributor to this repo so that they can continue to improve the action.

This was referenced Nov 12, 2021
Open
Open
Anton-Latukha pushed a commit to Anton-Latukha/actions that referenced this issue Nov 12, 2021
@rwe
Merge pull request haskell#81 from rwe/dependabot/npm_and_yarn/action…
e4b893d 
…s/tool-cache-1.7.1

Bump @actions/tool-cache from 1.6.0 to 1.7.1
Anton-Latukha added a commit to Anton-Latukha/actions that referenced this issue Nov 12, 2021
@Anton-Latukha
Merge actions-hlint-setup repo as /hlint-setup
78eb8c5 
History context:
1. https://github.com/rwe/actions-hlint-setup
2. ndmitchell/hlint#1311
3. haskell#81
4. current merger of "unrelated repo histories", current branch
& further merge request
Anton-Latukha pushed a commit to Anton-Latukha/actions that referenced this issue Nov 12, 2021
@rwe
Merge pull request haskell#81 from rwe/dependabot/npm_and_yarn/action…
11f4015 
…s/tool-cache-1.7.1

Bump @actions/tool-cache from 1.6.0 to 1.7.1
Anton-Latukha added a commit to Anton-Latukha/actions that referenced this issue Nov 12, 2021
@Anton-Latukha
Merge actions-hlint-run repo as /hlint-run
57fed1d 
History context:
1. https://github.com/rwe/actions-hlint-run
2. ndmitchell/hlint#1311
3. haskell#81
4. current merger of "unrelated repo histories", current branch
5. Merge request: haskell#85
...
This was referenced Nov 12, 2021
Merged
Closed
pbrisbin added a commit to freckle/haskell-library-template that referenced this issue Jun 13, 2022
@pbrisbin
Move to haskell/actions implementation
801cb3f 
haskell/actions#81
pbrisbin added a commit to freckle/haskell-library-template that referenced this issue Jun 13, 2022
@pbrisbin
Add HLint, tweak Spec.hs (#5)
b78bc28 
* Commit forgotten cabal file update

* Add conventional .hlint.yaml

This is the one from megarepo, but with the following tweaks:

- Adjust "within" on the restricted-qualification ignore
- Add an ignore for "Use Just"

* Standardize test executable

For a typical project (library), we use Spec.hs, not Main.hs. We use
Main.hs with a Spec.hs when we need to customize the runner.

Remove --module-name=Main.hs, as that's the default.

* Try newer HLint for glob support

* Move to haskell/actions implementation

haskell/actions#81

* Fixup
@brandonchinn178 brandonchinn178 mentioned this issue Nov 6, 2022
Closed
@andreasabel andreasabel added the re: hlint Concerning the hlint actions label Dec 22, 2022
@andreasabel
Copy link
Member

@hazelweakly

make @rwe a contributor to this repo so that they can continue to improve the action.

Hazel, could you please make me an admin of this repo so I can e.g. add @rwe as developer? Thanks, that would help greatly.

@andreasabel
Copy link
Member

Otherwise, there isn't anything left to do on this issue...

andreasabel pushed a commit to haskell-actions/setup that referenced this issue May 2, 2023
@Anton-Latukha
Merge actions-hlint-setup repo as /hlint-setup
0f828e9 
History context:
1. https://github.com/rwe/actions-hlint-setup
2. ndmitchell/hlint#1311
3. haskell/actions#81
4. current merger of "unrelated repo histories", current branch
& further merge request
andreasabel pushed a commit to haskell-actions/setup that referenced this issue May 2, 2023
@Anton-Latukha
Merge actions-hlint-run repo as /hlint-run
60b158f 
History context:
1. https://github.com/rwe/actions-hlint-run
2. ndmitchell/hlint#1311
3. haskell/actions#81
4. current merger of "unrelated repo histories", current branch
5. Merge request: haskell/actions#85
...
mihaimaruseac pushed a commit to haskell-actions/hlint-setup that referenced this issue Sep 17, 2023
@Anton-Latukha
Merge actions-hlint-setup repo as /hlint-setup
e63c16f 
History context:
1. https://github.com/rwe/actions-hlint-setup
2. ndmitchell/hlint#1311
3. haskell/actions#81
4. current merger of "unrelated repo histories", current branch
& further merge request
mihaimaruseac pushed a commit to haskell-actions/hlint-setup that referenced this issue Sep 17, 2023
@Anton-Latukha
Merge actions-hlint-run repo as /hlint-run
b8b38cd 
History context:
1. https://github.com/rwe/actions-hlint-run
2. ndmitchell/hlint#1311
3. haskell/actions#81
4. current merger of "unrelated repo histories", current branch
5. Merge request: haskell/actions#85
...
mihaimaruseac pushed a commit to haskell-actions/hlint-run that referenced this issue Sep 17, 2023
@Anton-Latukha
Merge actions-hlint-setup repo as /hlint-setup
e82419e 
History context:
1. https://github.com/rwe/actions-hlint-setup
2. ndmitchell/hlint#1311
3. haskell/actions#81
4. current merger of "unrelated repo histories", current branch
& further merge request
mihaimaruseac pushed a commit to haskell-actions/hlint-run that referenced this issue Sep 17, 2023
@Anton-Latukha
Merge actions-hlint-run repo as /hlint-run
2d786b9 
History context:
1. https://github.com/rwe/actions-hlint-run
2. ndmitchell/hlint#1311
3. haskell/actions#81
4. current merger of "unrelated repo histories", current branch
5. Merge request: haskell/actions#85
...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
re: hlint Concerning the hlint actions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andreasabel @Anton-Latukha @hazelweakly