Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

Fix macos cabal 3.4.0.0 rc4 #17

Merged
merged 2 commits into from
Dec 30, 2020

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Dec 21, 2020

This ensures that cabal-3.4.0.0-rc4 can be installed on MacOS

image

@newhoggy newhoggy force-pushed the fix-macos-cabal-3.4.0.0-rc4 branch 22 times, most recently from 8f883fa to 208fb99 Compare December 21, 2020 06:35
@newhoggy newhoggy force-pushed the fix-macos-cabal-3.4.0.0-rc4 branch from 208fb99 to ecf2995 Compare December 21, 2020 07:28
@newhoggy newhoggy changed the title [do not merge] Fix macos cabal 3.4.0.0 rc4 Fix macos cabal 3.4.0.0 rc4 Dec 21, 2020
@newhoggy newhoggy marked this pull request as ready for review December 21, 2020 09:11
@newhoggy
Copy link
Contributor Author

Resolves #15

@newhoggy newhoggy force-pushed the fix-macos-cabal-3.4.0.0-rc4 branch 2 times, most recently from 21d4f44 to 2e1b58e Compare December 21, 2020 23:23
@newhoggy newhoggy force-pushed the fix-macos-cabal-3.4.0.0-rc4 branch 3 times, most recently from 683a3b2 to 3ffb871 Compare December 22, 2020 00:02
@hazelweakly
Copy link
Collaborator

I commented on #15 about this. But I'll discuss the PR here.

Long story short, I don't think it makes sense to test cabal-install 3.4.0.0 in CI given that it's hitting a personal server to do so and that haskell's pre-releases aren't really in a state that they can be uniformly consumed across operating systems.

(This is not a mark on Haskell, GHC, or anyone else's hard work; it takes a very explicit push/goal as a community to invest that kind of effort into distributing/packaging prereleases.)

I would like to finally fix the cabal installing logic, however. So I'm looking forward to that.

setup/src/installer.ts Outdated Show resolved Hide resolved
@newhoggy newhoggy force-pushed the fix-macos-cabal-3.4.0.0-rc4 branch from 989fca9 to 4b87c46 Compare December 28, 2020 03:28
@newhoggy newhoggy force-pushed the fix-macos-cabal-3.4.0.0-rc4 branch from 4b87c46 to 371a760 Compare December 28, 2020 03:28
@newhoggy
Copy link
Contributor Author

Upstream fixes to ghcup means that it's now possible to test 3.4.0.0-rc4 without any workarounds.

@hazelweakly hazelweakly merged commit 7d4fdde into haskell:main Dec 30, 2020
Anton-Latukha pushed a commit to Anton-Latukha/actions that referenced this pull request Nov 12, 2021
…node-14.11.2

Bump @types/node from 14.6.0 to 14.11.2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants