Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpose gparseJson #655

Closed
bergmark opened this issue Jul 26, 2018 · 2 comments
Closed

Unexpose gparseJson #655

bergmark opened this issue Jul 26, 2018 · 2 comments
Milestone

Comments

@bergmark
Copy link
Collaborator

in #653 @Lysxia said

It's unfortunate that gParseJSON is exported in the toplevel modules Data.Aeson/Data.Aeson.Types. Users should really not depend on these Generics internals. It would be a good idea to hide this at some point [..] so we can just remove gParseJSON.

We should at least wait for #653 to be merged, then we can also rename the new gparseJson' to gparseJson at the same time. But I'd also like to avoid doing a major release since we had one recently and this change is mostly hygienic.

I wonder if anyone is using the current gparseJson? If they are they would probably like to use gparseJson' instead. Some investigation on aeson usages on hackage/stackage would be nice.

@Lysxia
Copy link
Collaborator

Lysxia commented Jul 26, 2018

Github-searching for gParseJSON returns 230 or so results, and almost all occurences are either gparseJSON from generic-aeson (that could be filtered out if Github search were case-sensitive) or in duplicates of the FromJSON module, so it was quick to go through all of them.

The only two actual matches are one inactive repo (unreleased) that just reexports it without using it, and a more active one that could certainly do without it (and that file is located under a directory named deprecated/...).

@phadej
Copy link
Collaborator

phadej commented Apr 4, 2020

Let's do this for 1.5

@bergmark bergmark added this to the next milestone Apr 4, 2020
bergmark added a commit that referenced this issue Apr 4, 2020
Fix #655: Don't export GFromJSON members from Data.Aeson(.Types)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants