Generate _qualified_ imports to avoid clashes with user code #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These have been untested since long.
andreasabel
force-pushed
the
qualified-imports
branch
from
27c215d
to
d873900
Compare
We can import the identifiers with `#` supported by all GHC versions unqualified from `GHC.Exts`, not expecting any clash with user code. Identifiers that are only known in newer versions of GHC, in conditional code, are referred to qualified, e.g. `GHC.Exts.foo`.
andreasabel
force-pushed
the
qualified-imports
branch
from
d873900
to
227ddbc
Compare
andreasabel
changed the title
andreasabel
force-pushed
the
qualified-imports
branch
from
227ddbc
to
8218d80
Compare
andreasabel
force-pushed
the
qualified-imports
branch
from
8218d80
to
f8fe5f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits:
#ifs)Fixes #258
GHC.Exts#258This could be released as 3.5.1.0 (minor bump), assuming that no one uses a contemporary
alexto generate code for compilation with GHC 6.2 or lower.Candidate: https://hackage.haskell.org/package/alex-3.5.1.0/candidate