v1.0 Omnibus #10
Merged
v1.0 Omnibus #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilypi
commented
Jun 16, 2020
|
|
||
| c2w :: Char -> Word8 | ||
| c2w = fromIntegral . ord | ||
| {-# INLINE c2w #-} |
There was a problem hiding this comment.
unsafeShiftR and c2w are for GHC <= 7.4
- 4.5x decode, 3.5x encode performance - A change to the decode api model - Lenient decoders - RFC 4648-compliant tests - Property tests - Better haddocks + since annotations - Update cabal file to include benches + bump versions
Closed
…into v1.0-overhaul
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title. This PR does the following:
decodesignature returning the tuple and actually returns an error message with offset. The signature will now beByteString -> Either String ByteString.-XTrustworthyannotations to the relevant exposed modules.cabalfile so they can be run at toplevel, and make them better.This is a major API overhaul and cause lots of breakages. Consequently, I suggest we bump to version
1.0.0.0.