Add check for "ghc-options: -j"

haskell · Apr 20, 2018 · baea4fc · baea4fc
1 parent 4818eb5
commit baea4fc
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/Cabal/Distribution/PackageDescription/Check.hs b/Cabal/Distribution/PackageDescription/Check.hs
@@ -1708,6 +1708,12 @@ checkDevelopmentOnlyFlagsBuildInfo bi =
         ++ "add new warnings. "
         ++ extraExplanation
 
+  , check (has_J) $
+      PackageDistInexcusable $
+           "'ghc-options: -j[N]' can make sense for specific user's setup,"
+        ++ " but it is not appropriate for a distributed package."
+        ++ extraExplanation
+
   , checkFlags ["-fdefer-type-errors"] $
       PackageDistInexcusable $
            "'ghc-options: -fdefer-type-errors' is fine during development but "
@@ -1745,6 +1751,13 @@ checkDevelopmentOnlyFlagsBuildInfo bi =
     has_Werror       = "-Werror" `elem` ghc_options
     has_Wall         = "-Wall"   `elem` ghc_options
     has_W            = "-W"      `elem` ghc_options
+    has_J            = any
+                         (\o -> case o of
+                           "-j"                -> True
+                           ('-' : 'j' : d : _) -> isDigit d
+                           _                   -> False
+                         )
+                         ghc_options
     ghc_options      = hcOptions GHC bi ++ hcProfOptions GHC bi
                        ++ hcSharedOptions GHC bi