Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for "ghc-options: -j" #5277

Merged
merged 2 commits into from
May 25, 2018

Conversation

lspitzner
Copy link
Collaborator

Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

@quasicomputational
Copy link
Contributor

Good idea. Can I ask for a changelog note and a new test for this behaviour? It looks simple but I know I've written simple and wrong code, and it'd keep the feature from accidentally breaking later.

@23Skidoo
Copy link
Member

23Skidoo commented May 9, 2018

Rebased on top of current master.

Copy link
Member

@23Skidoo 23Skidoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@quasicomputational
Copy link
Contributor

Ah, found a nit: the error message mentions ghc-options but it might actually have been in ghc-shared-options or ghc-prof-options. But the rest of the code follows this pattern so I'll open up a bug as a TODO on fixing that.

In the meantime, I pushed a test and a changelog note for this; once Travis comes back green I'll go ahead and push the big green button.

@quasicomputational quasicomputational merged commit 7783ad1 into haskell:master May 25, 2018
@lspitzner lspitzner deleted the warn-ghc-j branch September 1, 2018 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants