Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show full installed package ABI hash test fails. #6495

Closed
phadej opened this issue Jan 20, 2020 · 6 comments · Fixed by #6496 or #6498
Closed

show full installed package ABI hash test fails. #6495

phadej opened this issue Jan 20, 2020 · 6 comments · Fixed by #6496 or #6498
Labels
cabal-install: solver

Comments

@phadej
Copy link
Collaborator

phadej commented Jan 20, 2020 

Unit Tests
  UnitTests.Distribution.Solver.Modular.Solver
    Solver log
      show full installed package ABI hash (issue #5892):                    FAIL
        tests/UnitTests/Distribution/Solver/Modular/DSL/TestCaseUtils.hs:245:
        Unexpected error:
        Could not resolve dependencies:
        [__0] trying: my-package-1.0.0 (user goal)
        [__1] next goal: other-package (dependency of my-package)
        [__1] rejecting: other-package-2.0.0/installed-2.0.0.0 (conflict: my-package => other-package==3.0.0)
        [__1] skipping: other-package-1.0.0/installed-AbCdEfGhIj0123456789 (has the same characteristics that caused the previous version to fail: excluded by constraint '==3.0.0' from 'my-package')
        [__1] fail (backjumping, conflict set: my-package, other-package)
        After searching the rest of the dependency tree exhaustively, these were the goals I've had most trouble fulfilling: my-package, other-package
@phadej
Copy link
Collaborator Author

phadej commented Jan 20, 2020 •
edited
Loading

cc @grayjay Not the same as concatenated msg you look for. I'm reverting #6476

@phadej phadej mentioned this issue Jan 20, 2020
Merged
@phadej
Copy link
Collaborator Author

phadej commented Jan 20, 2020

I can reproduce it locally on fbe7d73 by make validate-via-docker-8.0.2

@grayjay
Copy link
Collaborator

grayjay commented Jan 20, 2020

It looks like the test is failing because #5918 changed the solver output. I'll update the test.

@phadej
Copy link
Collaborator Author

phadej commented Jan 20, 2020 •
edited
Loading

I'll merge #6496 (the revert) as soon as CI is happy. Again, I'd like to have a single working commit that I could cherry-pick to 3.2.

EDIT... so please wait until that, and redo the pull request on the future master.

@grayjay
Copy link
Collaborator

grayjay commented Jan 20, 2020

Okay. Thanks!

@phadej
Copy link
Collaborator Author

phadej commented Jan 20, 2020

reverted

grayjay added a commit to grayjay/cabal that referenced this issue Jan 21, 2020
@grayjay
Show full ABI hash for installed packages in solver log (fixes haskel…
4660e90 
…l#5892).

This commit is the same as 96c3bf9, but with
the unit tests updated to fix haskell#6495.  The tests check less of the solver output
so that they are less fragile.
@grayjay grayjay mentioned this issue Jan 21, 2020
Merged
phadej pushed a commit to phadej/cabal that referenced this issue Jan 22, 2020
@grayjay @phadej
Show full ABI hash for installed packages in solver log (fixes haskel…
ec64fc0 
…l#5892).

This commit is the same as 96c3bf9, but with
the unit tests updated to fix haskell#6495.  The tests check less of the solver output
so that they are less fragile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cabal-install: solver
Projects
None yet
Milestone
No milestone
2 participants
@phadej @grayjay