Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cabal init produces extra-source-files: CHANGELOG.md #6864

Closed
juhp opened this issue May 30, 2020 · 5 comments · Fixed by #7344
Closed

cabal init produces extra-source-files: CHANGELOG.md #6864

juhp opened this issue May 30, 2020 · 5 comments · Fixed by #7344
Labels
attention: pr-welcome cabal-install: cmd/init type: bug

Comments

@juhp
Copy link
Collaborator

juhp commented May 30, 2020 •
edited
Loading

Describe the bug
CHANGELOG.md(sic ChangeLog.md) (and README.md) should be listed as extra-doc-files not extra-source-files (see also #5813).

To Reproduce
Steps to reproduce the behavior:

$ cabal init --non-interactive

Please use version-prefixed commands (e.g. v2-build or v1-build) to avoid ambiguity.

Expected behavior
extra-doc-files: CHANGELOG.md

System information

  • Operating system: Fedora
  • cabal-3.2.0.0, ghc-8.6.5 versions

Additional context
extra-source-files: CHANGELOG.md is put in .cabal file.
@juhp juhp changed the title cabal init uses extra-source-files: CHANGELOG.md cabal init produces extra-source-files: CHANGELOG.md May 30, 2020
@phadej
Copy link
Collaborator

phadej commented May 31, 2020

Note that extra-doc-files is cabal-version: 1.18 (IIRC. please check) feature.

@juhp
Copy link
Collaborator Author

juhp commented Jun 1, 2020

Note that extra-doc-files is cabal-version: 1.18 (IIRC. please check) feature.

Okay but cabal init now produces cabal-version: 2.4 anyway, right?

@phadej
Copy link
Collaborator

phadej commented Jun 1, 2020

Okay but cabal init now produces cabal-version: 2.4 anyway, right?

Interactive variant still could be selected to produce 1.10.

@juhp
Copy link
Collaborator Author

juhp commented Jun 1, 2020

Gotya, good point!

I think you are right: #3825.

@emilypi emilypi mentioned this issue Apr 14, 2021
Merged
11 tasks
emilypi added a commit to ptkato/cabal that referenced this issue May 5, 2021
@emilypi
add adaptive fix for haskell#6864
e398baa
@juhp
Copy link
Collaborator Author

juhp commented May 27, 2021

Haven't tested yet, but thanks a lot for addressing this!

ptkato pushed a commit to ptkato/cabal that referenced this issue May 31, 2021
@emilypi @ptkato
add adaptive fix for haskell#6864
aeb6623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
attention: pr-welcome cabal-install: cmd/init type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cabal Init Omnibus ptkato/cabal
3 participants
@phadej @juhp @m-renaud