Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: cabal-testsuite tests fail with "double directory" #8883

Closed
ulysses4ever opened this issue Mar 30, 2023 · 6 comments
Closed

CI: cabal-testsuite tests fail with "double directory" #8883

ulysses4ever opened this issue Mar 30, 2023 · 6 comments

Comments

@ulysses4ever
Copy link
Collaborator

It was observed earlier on Windows:

but since GHC 9.6.1 it plagues the other platforms too. Here's one recent CI run.

PackageTests/NewBuild/CmdRun/Terminate/cabal.test.hs:4:1: error:
Error:     Ambiguous module name ‘System.Directory’:
      it was found in multiple packages:
      directory-1.3.8.1 directory-1.3.8.1
  |
4 | import System.Directory (removeFile)
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Due to this error I had to disable cabal-testsuite altogether for 9.6.1 in #8840.

@Mikolaj
Copy link
Member

Mikolaj commented Mar 30, 2023

High priority IMHO. Even if it's just that some tests are expected to trash the store, but they are not properly isolated, we need to weed them out. It can also be an actual bug. Either way, disabling our CI is a tragedy that will lead to other serious bugs introduced undetected.

@jgotoh
Copy link
Member

jgotoh commented Oct 12, 2023

I have this bug on my machine running with ghc 9.2.8 and cabal 3.10.1.0. Can I help you debug this somehow? Every test that imports System.Directory in the cabal-testsuite does not work for me

@Mikolaj
Copy link
Member

Mikolaj commented Oct 30, 2023

@jgotoh: thank you very much. At some point @grayjay wanted to have a look at a log of a failed run (now provided in #8356), so I guess having a local reproducing checkout or hints about how to set up one could be valuable as well.

@ulysses4ever
Copy link
Collaborator Author

@Mikolaj should we close this on favor of #8356? I thought the title and description here is a little more clear, but you seem to be posting updates there. So, currently it's a bit confusing.

@Mikolaj
Copy link
Member

Mikolaj commented Oct 30, 2023

I've now stolen your ticket title and description, so we can safely close this now. :)

@Mikolaj Mikolaj closed this as completed Oct 30, 2023
@ulysses4ever
Copy link
Collaborator Author

Only good things get stolen, so I'm happy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants