Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required-fields to changelog.d config (backport #9810) #10005

Merged
merged 4 commits into from
May 14, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/changelogs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,14 @@ jobs:
ghcup set ghc recommended
- name: Update Hackage index
run: cabal v2-update
# Cannot install it from tarball due to
# Cannot install it directly from remote tarball due to
# https://github.com/haskell/cabal/issues/7360
- uses: actions/checkout@v4
with:
repository: "fgaz/changelog-d"
path: "changelog-d"
- name: Fetch changelog-d
run: |
changelog_d_latest="$(curl https://codeberg.org/api/v1/repos/fgaz/changelog-d/branches/master | jq -r .commit.id)"
echo "Using changelog-d revision $changelog_d_latest"
curl "https://codeberg.org/fgaz/changelog-d/archive/$changelog_d_latest.tar.gz" -o changelog-d.tar.gz
tar -xf changelog-d.tar.gz
- name: Install changelog-d
run: |
pushd changelog-d
Expand Down
1 change: 1 addition & 0 deletions changelog.d/config
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
organization: haskell
repository: cabal
required-fields: packages prs
10 changes: 10 additions & 0 deletions changelog.d/issue-8680
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
synopsis: `cabal init` should not suggest Cabal < 2.0
packages: Cabal
issues: #8680
prs: #8700

description: {

'cabal init' no longer suggests users to set cabal-version to less than 2.0

}
19 changes: 19 additions & 0 deletions changelog.d/issue-9098-lexbraces
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
synopsis: Add LexBraces lexer warning
packages: Cabal-syntax
issues: #9098
prs: #9099

description: {

LexBraces warning is issued when brace delimiting syntax is used.
This way, using `readFields'`, a low-lever consumer may decide
whether braces were used.

(Looking for a brace character in the input is imprecise, as braces can occur inside field content).

This warning is not propagated to parser warnings,
so e.g. readGenericPackageDescription doesn't warn about it.
This is because all parser warnings prevent uploads to Hackage,
and using braces (or not) is opinionated choice.

}
17 changes: 17 additions & 0 deletions changelog.d/issue-9678
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
synopsis: Clarify the semantics of the -package-db flag
packages: cabal-install
prs:
issues: #9678
prs: #9683

description: {

The `--package-db` flag now only applies to the default
immutable initial package stack rather than also applying to the store
package database.

This fixes an assertion failure which was triggered when using -package-db and also
clarifies how it should interact with `--store-dir` and `--dist-dir` flags.

}

12 changes: 12 additions & 0 deletions changelog.d/issue-9736
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
synopsis: Add support for `GHC2024`
packages: Cabal cabal-install
issues: #9736
prs: #9791

description: {

Support for the `GHC2024` language edition, introduced by GHC 9.10, has been
added. It can now be used in the `default-language` and `other-languages`
fields, and will be offered as an option by `cabal init`.

}
9 changes: 9 additions & 0 deletions changelog.d/pkgconfig-once
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
synopsis: PkgConfig individual calls
prs: #9134
packages: cabal-install-solver

description: {

- `cabal` invokes `pkg-config` individually for each lib if querying for all doesn't return the expected result

}
Loading