Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add “Add default-language” suggestion (backport #9766) #10023

Merged
merged 1 commit into from
May 16, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 16, 2024

Closes #9620

Add a warning ("Hackage would refuse this package") when default-language is missing. Done to prepare the user to GHC language editions.


Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • Manual QA notes have been included.
  • Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

** QA notes **

  1. cabal init a package, choose cabal-version 3.4
  2. run cabal check
  3. old cabal: it will not complain about missing default-language
  4. new cabal: it wil complain about missing default-language
    This is an automatic backport of pull request Add “Add default-language” suggestion #9766 done by Mergify.

As a warning (“Hackage would reject this package”), to prepare users
to GHC language editions.

(cherry picked from commit f9d2af4)
@mergify mergify bot mentioned this pull request May 16, 2024
5 tasks
@mergify mergify bot added the backport label May 16, 2024
@Kleidukos Kleidukos requested a review from ulysses4ever May 16, 2024 14:40
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This technically doesn't qualify for bugfix, perhaps, but having consistent behaviour of cabal check between master and 3.12 is important.

@ulysses4ever ulysses4ever added the merge me Tell Mergify Bot to merge label May 16, 2024
@mergify mergify bot merged commit 1b5ff69 into 3.12 May 16, 2024
43 checks passed
@mergify mergify bot deleted the mergify/bp/3.12/pr-9766 branch May 16, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants