Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelogs for 3.12.1.0 #10124

Merged
merged 9 commits into from
Jun 21, 2024
Merged

Changelogs for 3.12.1.0 #10124

merged 9 commits into from
Jun 21, 2024

Conversation

geekosaur
Copy link
Collaborator

@geekosaur geekosaur commented Jun 19, 2024 •
edited
Loading

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

Closes #10086

@geekosaur geekosaur force-pushed the changelog-3.12.1.0 branch 2 times, most recently from 56b3547 to 3bfbdf2 Compare June 19, 2024 01:27
@geekosaur
Copy link
Collaborator Author

  1. Someone should verify my choices for what counted as major vs. minor changes.
  2. I have no idea what the whitespace job is looking for. I tried to copy release-notes/Cabal-3.12.0.0.md's format.

@geekosaur
Copy link
Collaborator Author

  1. I was surprised that only 6 changelog entries were created for cabal-install since the WIP changelog was last updated. Is that correct? (It might be, since changelog.d was pretty empty.)
  2. Should I go ahead and rename the WIP changelog to its final name?

@Mikolaj
Copy link
Member

Mikolaj commented Jun 19, 2024

  1. whitespace

Isn't this a whitespace bug?

"Cabal will succeed if "

  1. I was surprised that only 6 changelog entries were created

I've commented in the channel.

  1. Should I go ahead and rename the WIP changelog to its final name?

Absolutely, though maybe after the missing changelogs are brought back.

@ulysses4ever ulysses4ever mentioned this pull request Jun 19, 2024
Closed
18 tasks
@ulysses4ever
Copy link
Collaborator

Could someone please check that this is addressed: #10086

@geekosaur geekosaur linked an issue Jun 19, 2024 that may be closed by this pull request
Changelog for Cabal 3.12 is missing mention of error codes #10086
Closed
ulysses4ever
ulysses4ever reviewed Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy-editing Cabal (the lib) notes.

release-notes/Cabal-3.12.1.0.md Outdated Show resolved Hide resolved
release-notes/Cabal-3.12.1.0.md Outdated Show resolved Hide resolved
release-notes/Cabal-3.12.1.0.md Outdated Show resolved Hide resolved
release-notes/Cabal-3.12.1.0.md Outdated Show resolved Hide resolved
release-notes/Cabal-3.12.1.0.md Outdated Show resolved Hide resolved
release-notes/Cabal-3.12.1.0.md Outdated Show resolved Hide resolved
release-notes/Cabal-3.12.1.0.md Outdated Show resolved Hide resolved
ulysses4ever
ulysses4ever reviewed Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ibid (for cabal-install)

release-notes/cabal-install-3.12.1.0.md Outdated Show resolved Hide resolved
release-notes/cabal-install-3.12.1.0.md Outdated Show resolved Hide resolved
release-notes/cabal-install-3.12.1.0.md Outdated Show resolved Hide resolved
release-notes/cabal-install-3.12.1.0.md Outdated Show resolved Hide resolved
release-notes/cabal-install-3.12.1.0.md Outdated Show resolved Hide resolved
@ulysses4ever
Copy link
Collaborator

ulysses4ever commented Jun 19, 2024 •
edited
Loading

PSA: the PR's merged into 3.12 branch can be browsed via https://github.com/haskell/cabal/pulls?q=is%3Apr+sort%3Aupdated-desc+base%3A3.12+is%3Aclosed

I think #10123 deserves a mention to make the users more aware of performance improvements they can expect. This could increase the number of early adopters.

I'd also mention #9917 along the following lines in cabal-install release notes:

This is the first release compatible with Cabal 3.12 distributed with GHC 9.10. It unlocks custom setup builds with GHC 9.10. #9917

@ulysses4ever
Copy link
Collaborator

ulysses4ever commented Jun 19, 2024 •
edited
Loading

I think #10108 is also missing a changelog. Could we add an entry in the list manually?

@geekosaur
Copy link
Collaborator Author

I did for the error messages. Speak now or forever hold your peace!

@ulysses4ever
Copy link
Collaborator

Can't promise the forever part :-) I may have another look at the PR list I referenced above

@geekosaur
Copy link
Collaborator Author

It's "forever" once I hand it off to Mergify 😀

@ulysses4ever
Copy link
Collaborator

So, shall we move forward?

@geekosaur
Copy link
Collaborator Author

I put it on the docket for tomorrow.

ffaf1
ffaf1 approved these changes Jun 20, 2024
View reviewed changes
release-notes/Cabal-3.12.1.0.md Outdated Show resolved Hide resolved
release-notes/Cabal-3.12.1.0.md Outdated Show resolved Hide resolved
release-notes/cabal-install-3.12.1.0.md Show resolved Hide resolved
@geekosaur
Copy link
Collaborator Author

Are we go?

@ulysses4ever
Copy link
Collaborator

I think we should

@geekosaur geekosaur added squash+merge me Tell Mergify Bot to squash-merge and removed attention: needs-review labels Jun 21, 2024
@mergify mergify bot merged commit 2067ed1 into 3.12 Jun 21, 2024
53 checks passed
@mergify mergify bot deleted the changelog-3.12.1.0 branch June 21, 2024 02:55
@geekosaur
Copy link
Collaborator Author

@mergify backport master

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 21, 2024 •
edited
Loading

backport master

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 21, 2024
@geekosaur @mergify
Changelogs for 3.12.1.0 (#10124)
0cc2c16 
* changelog for 3.12.1.0

* fixup! changelog for 3.12.1.0

* fixup! Changelogs for 3.12.1.0

Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com>

* fixup! changelog for 3.12.1.0

* fixup! changelog for 3.12.1.0

* fixup! Changelogs for 3.12.1.0

Co-authored-by: ffaf1 <fa-ml@ariis.it>

* fixup! Changelogs for 3.12.1.0

* fixup! Changelogs for 3.12.1.0

* fixup! Changelogs for 3.12.1.0

---------

Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com>
Co-authored-by: ffaf1 <fa-ml@ariis.it>
(cherry picked from commit 2067ed1)

# Conflicts:
#	release-notes/Cabal-3.12.0.0.md
@mergify mergify bot mentioned this pull request Jun 21, 2024
Merged
2 tasks
geekosaur added a commit that referenced this pull request Jun 21, 2024
@geekosaur
fixup! Changelogs for 3.12.1.0 (backport #10124)
9a8f2b8
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Jun 23, 2024
mergify bot added a commit that referenced this pull request Jun 25, 2024
@mergify @geekosaur
Changelogs for 3.12.1.0 (backport #10124) (#10132)
ffcadaa 
* Changelogs for 3.12.1.0 (#10124)

* changelog for 3.12.1.0

* fixup! changelog for 3.12.1.0

* fixup! Changelogs for 3.12.1.0

Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com>

* fixup! changelog for 3.12.1.0

* fixup! changelog for 3.12.1.0

* fixup! Changelogs for 3.12.1.0

Co-authored-by: ffaf1 <fa-ml@ariis.it>

* fixup! Changelogs for 3.12.1.0

* fixup! Changelogs for 3.12.1.0

* fixup! Changelogs for 3.12.1.0

---------

Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com>
Co-authored-by: ffaf1 <fa-ml@ariis.it>
(cherry picked from commit 2067ed1)

# Conflicts:
#	release-notes/Cabal-3.12.0.0.md

* fixup! Changelogs for 3.12.1.0 (backport #10124)

---------

Co-authored-by: brandon s allbery kf8nh <allbery.b@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
jasagredo pushed a commit to jasagredo/cabal that referenced this pull request Jun 26, 2024
@mergify @geekosaur @jasagredo
Changelogs for 3.12.1.0 (backport haskell#10124) (haskell#10132)
a51ac45 
* Changelogs for 3.12.1.0 (haskell#10124)

* changelog for 3.12.1.0

* fixup! changelog for 3.12.1.0

* fixup! Changelogs for 3.12.1.0

Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com>

* fixup! changelog for 3.12.1.0

* fixup! changelog for 3.12.1.0

* fixup! Changelogs for 3.12.1.0

Co-authored-by: ffaf1 <fa-ml@ariis.it>

* fixup! Changelogs for 3.12.1.0

* fixup! Changelogs for 3.12.1.0

* fixup! Changelogs for 3.12.1.0

---------

Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com>
Co-authored-by: ffaf1 <fa-ml@ariis.it>
(cherry picked from commit 2067ed1)

# Conflicts:
#	release-notes/Cabal-3.12.0.0.md

* fixup! Changelogs for 3.12.1.0 (backport haskell#10124)

---------

Co-authored-by: brandon s allbery kf8nh <allbery.b@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysangkok ysangkok ysangkok left review comments

@ulysses4ever ulysses4ever ulysses4ever approved these changes

@ffaf1 ffaf1 ffaf1 approved these changes

Assignees
No one assigned
Labels
attention: backport after release merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days release squash+merge me Tell Mergify Bot to squash-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changelog for Cabal 3.12 is missing mention of error codes
5 participants
@geekosaur @Mikolaj @ulysses4ever @ysangkok @ffaf1