Use msys2 shell on Windows GHA runners
#10125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
force-pushed
the
js/msys2-shell-validate
branch
2 times, most recently
from
19ac0b4
to
c2e8416
Compare
geekosaur
approved these changes
Jun 19, 2024
Kleidukos
approved these changes
Jun 20, 2024
ulysses4ever
approved these changes
Jun 20, 2024
|
We normally use Mergify for this, rather than merging directly. It helps keep merge history straight. |
|
I vouch for this direct merge, I didn't see the point in going through applying two labels (merge and delay-passed) for this. |
|
I'd prefer that we stick to Mergify unless there's a feeling of urgency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.