Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: Use cabal doctest #10231

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Makefile: Use cabal doctest #10231

merged 1 commit into from
Jul 30, 2024

Conversation

sol
Copy link
Member

@sol sol commented Jul 27, 2024

No description provided.

@geekosaur
Copy link
Collaborator

Looks like cabal-doctest has a problem with --allow-newer? https://github.com/haskell/cabal/actions/runs/10119868982/job/27988903129?pr=10231#step:9:12

@sol
Copy link
Member Author

sol commented Jul 27, 2024

Looks like cabal-doctest has a problem with --allow-newer?

Actually, all options with optional arguments are affected.

This will be fixed by sol/doctest#445.

@sol sol force-pushed the patch-1 branch 3 times, most recently from c45f61a to 811dc14 Compare July 27, 2024 23:19
@sol sol marked this pull request as ready for review July 27, 2024 23:24
@sol sol mentioned this pull request Jul 28, 2024
Open
sol
sol commented Jul 28, 2024
View reviewed changes
Makefile
cd Cabal-described && $(DOCTEST)
cd Cabal && $(DOCTEST)
cd cabal-install-solver && $(DOCTEST)
cd cabal-install && $(DOCTEST)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geekosaur changing the working directory is necessary as per #9115 (comment).

Other than that, this is good to go.

@sol sol requested a review from philderbeast July 28, 2024 04:06
ulysses4ever
ulysses4ever approved these changes Jul 28, 2024
View reviewed changes
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love those cd's but I think we should be conducive to contributions that exercise cabal latest features (e.g. external commands). A big +1 from me.

@sol
Copy link
Member Author

sol commented Jul 28, 2024

I don't love those cd's

I definitely agree. I think #9115 is the way to fix that.

@sol sol added the merge me Tell Mergify Bot to merge label Jul 28, 2024
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Jul 30, 2024
@mergify mergify bot merged commit ee1fd52 into haskell:master Jul 30, 2024
50 checks passed
@sol sol deleted the patch-1 branch July 31, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekosaur geekosaur geekosaur approved these changes

@ulysses4ever ulysses4ever ulysses4ever approved these changes

@philderbeast philderbeast Awaiting requested review from philderbeast

Assignees
No one assigned
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sol @geekosaur @ulysses4ever