Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows tests depending on scripts #10236

Merged
merged 6 commits into from
Sep 4, 2024
Merged

Fix Windows tests depending on scripts #10236

merged 6 commits into from
Sep 4, 2024

Conversation

jasagredo
Copy link
Collaborator

Using the shim program (https://github.com/haskell/ghcup-hs/tree/master/scoop-better-shimexe) (thanks @hasufell) I was able to make some more tests pass.

Closes #10179
Depends on: #10225

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).
    • Yes, but I don't think this needs a backport

Mikolaj
Mikolaj approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One has to do what one has to do IMHO. Much more important to have the tests running for Windows.

@jasagredo jasagredo force-pushed the js/win-scripts branch 7 times, most recently from 929eb10 to a5a632b Compare September 1, 2024 22:17
@jasagredo jasagredo added the merge me Tell Mergify Bot to merge label Sep 2, 2024
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Sep 2, 2024
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Sep 4, 2024
@mergify mergify bot merged commit a092bc8 into haskell:master Sep 4, 2024
49 checks passed
@Kleidukos
Copy link
Member

@Mergifyio backport 3.14

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 5, 2024 •
edited
Loading

backport 3.14

✅ Backports have been created

@mergify mergify bot mentioned this pull request Sep 5, 2024
Merged
2 tasks
mergify bot added a commit that referenced this pull request Oct 2, 2024
@mergify
Merge pull request #10319 from haskell/mergify/bp/3.14/pr-10236
57cbb08 
Fix Windows tests depending on scripts (backport #10236)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kleidukos Kleidukos Kleidukos approved these changes

@Mikolaj Mikolaj Mikolaj approved these changes

Assignees
No one assigned
Labels
attention: needs-backport 3.14 merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge platform: windows ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide .bat alternatives to test scripts
3 participants
@jasagredo @Kleidukos @Mikolaj