Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MultilineStrings extension #10245

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

brandonchinn178
Copy link
Collaborator

@brandonchinn178 brandonchinn178 commented Aug 3, 2024

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • Manual QA notes have been included.
  • Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray!

Although, Cabal-tests/tests/UnitTests/Distribution/Utils/Structured.hs will probably have to be updated.

@brandonchinn178
Copy link
Collaborator Author

That's... annoying 🫤 Any reason why it's not just a golden test? It would be more auditable and easier to update.

Presumably CI will fail with the new hash, right? I'll update when that happens.

@Kleidukos Kleidukos mentioned this pull request Aug 3, 2024
20 tasks
@brandonchinn178 brandonchinn178 force-pushed the bchinn-multiline-strings branch from 4e9f2e2 to e0bbb97 Compare August 3, 2024 23:09
@brandonchinn178 brandonchinn178 merged commit 72e5439 into master Aug 6, 2024
51 checks passed
@brandonchinn178 brandonchinn178 deleted the bchinn-multiline-strings branch August 6, 2024 06:16
@ulysses4ever
Copy link
Collaborator

Hey @brandonchinn178! Thanks for your contribution! Please, check out our contributing guidelines w.r.t. GitHub PR lifecycle: https://github.com/haskell/cabal/blob/master/CONTRIBUTING.md#github-pull-request-conventions We don't merge manually and rather defer to a bot, which implements a cooldown period among other things. A PR author is supposed to apply a merge label when they are ready to hand the PR over to the bot.

@brandonchinn178
Copy link
Collaborator Author

ah sorry! Happy to do any revert operations, just let me know

@ulysses4ever
Copy link
Collaborator

No, that's fine. Just for the future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants