validate.sh: --jobs should default to nproc
#10315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have 16 cores, but I also have quite a lot going on on my machine and would prefer validates not interfere. I think the idea of 4 is a reasonable default that can be overridden depending on environment. |
|
@geekosaur Sure, I don't think we should remove the |
ulysses4ever
approved these changes
Sep 6, 2024
geekosaur
approved these changes
Sep 6, 2024
mergify
bot
added
ready and waiting
If `nproc` is available and `--jobs` is not given, this will use the output of `nproc` as the value for `--jobs`. Otherwise, the old default value of 4 will be used and a warning will be printed. The default value of 4 has remained unchanged since it was added in 6a9a101 in 2018; that may have been a reasonable number of cores then, but my development machine today has 20 cores, so setting the parallelism to 4 leaves a lot of performance on the table!
Mikolaj
force-pushed
the
validate-jobs-nproc
branch
from
6b9bacf to
00c9b65
Compare
|
@mergify backport 3.12 |
✅ Backports have been created
|
mergify bot
added a commit
that referenced
this pull request
Sep 14, 2024
validate.sh: `--jobs` should default to `nproc` (backport #10315)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
nprocis available and--jobsis not given, this will use the output ofnprocas the value for--jobs.Otherwise, the old default value of 4 will be used and a warning will be printed.
The default value of 4 has remained unchanged since it was added in 6a9a101 in 2018; that may have been a reasonable number of cores then, but my development machine today has 20 cores, so setting the parallelism to 4 leaves a lot of performance on the table!