Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Makefile targets for fix-whitespace #10376

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

geekosaur
Copy link
Collaborator

@geekosaur geekosaur commented Sep 20, 2024

make whitespace now runs fix-whitespace --check --verbose and make fix-whitespace runs fix-whitespace --verbose. You will need to install fix-whitespace yourself, but that's just a cabal install away.

This is another step in the direction of fixing #10263.

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

Copy link
Member

@Kleidukos Kleidukos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic

@ulysses4ever
Copy link
Collaborator

I wish any new target in the makefile came with two things:

  1. Update to documentation (probably, CONTRIBUTING.md) mentioning the target. It helps visibility.

  2. Update to CI so that CI exercises the target. It helps avoid bit-rotting.

@Kleidukos
Copy link
Member

This is a reasonable request yes

@geekosaur geekosaur force-pushed the make-fix-whitespace branch 3 times, most recently from b493d98 to ca2cbc4 Compare September 26, 2024 21:56
@geekosaur geekosaur added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Sep 27, 2024
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Sep 27, 2024
`make whitespace` now runs `fix-whitespace --check --verbose` and
`make fix-whitespace` runs `fix-whitespace --verbose`.
@Mikolaj Mikolaj force-pushed the make-fix-whitespace branch from ca2cbc4 to 2858dc0 Compare September 29, 2024 02:33
@mergify mergify bot merged commit 4d298d3 into haskell:master Sep 29, 2024
41 checks passed
@Kleidukos
Copy link
Member

@Mergifyio backport 3.14

Copy link
Contributor

mergify bot commented Oct 8, 2024

backport 3.14

✅ Backports have been created

mergify bot added a commit that referenced this pull request Oct 8, 2024
add Makefile targets for fix-whitespace (backport #10376)
@Kleidukos
Copy link
Member

@Mergifyio backport 3.12

Copy link
Contributor

mergify bot commented Oct 8, 2024

backport 3.12

✅ Backports have been created

mergify bot added a commit that referenced this pull request Oct 8, 2024
add Makefile targets for fix-whitespace (backport #10376)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants