Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment optional post-install field in the ghcup metadata script and fix typos #10643

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Comment optional post-install field in the ghcup metadata script and fix typos #10643

wants to merge 1 commit into from

Conversation

Kleidukos
Copy link
Member

No description provided.

@Kleidukos Kleidukos mentioned this pull request Dec 16, 2024
Merged
@Kleidukos Kleidukos requested a review from geekosaur December 17, 2024 00:19
@Kleidukos
Copy link
Member Author

@geekosaur A second look would be appreciated

@Kleidukos
Copy link
Member Author

cc @arjunkathuria

geekosaur
geekosaur approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay as far as I can tell, but I'm not really an expert in ghcup's YAML metadata.

@Kleidukos Kleidukos force-pushed the fixes-to-the-ghcup-metadata-script branch from 430274a to ae0455a Compare December 17, 2024 13:56
@Kleidukos Kleidukos marked this pull request as ready for review December 19, 2024 18:13
@geekosaur
Copy link
Collaborator

FWIW the * vs. & stuff is YAML anchors.

@Kleidukos
Copy link
Member Author

@geekosaur any idea about https://github.com/haskell/cabal/actions/runs/12418397255/job/34675419181?pr=10643 ?

@Kleidukos Kleidukos force-pushed the fixes-to-the-ghcup-metadata-script branch from b0b7235 to 4b1af4a Compare December 26, 2024 11:27
@geekosaur
Copy link
Collaborator

I'm going to be trying a different release action, since Artem's rewiring of the delete-release action #10662 (which you don't seem to have in your roll-up) isn't working. The likely one is nightly-release which I found in the Marketplace.

@geekosaur
Copy link
Collaborator

Also you may not have my final fix of the LTS prerelease, which included some debug cleanup that turned off the initial steps always running,

@geekosaur geekosaur closed this Dec 26, 2024
@geekosaur geekosaur reopened this Dec 26, 2024
@geekosaur
Copy link
Collaborator

Sorry, wrong button, I'm barely awake

@Kleidukos
Copy link
Member Author

I rebased on master 10mn ago, it should be good?

@geekosaur
Copy link
Collaborator

I rebased on master 10mn ago, it should be good?

"Should be", but that was definitely the LTS prerelease that was running, meaning you were missing the final cleanup (#10655) that put the guards back on it.

@Kleidukos Kleidukos added the merge me Tell Mergify Bot to merge label Dec 27, 2024
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulysses4ever ulysses4ever ulysses4ever approved these changes

@geekosaur geekosaur geekosaur approved these changes

Assignees
No one assigned
Labels
merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kleidukos @geekosaur @ulysses4ever