Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

second attempt at catching stale PRs #10648

Closed
wants to merge 1 commit into from

Conversation

geekosaur
Copy link
Collaborator

The first one didn't fire, despite there being 3 PRs that should have matched. This one tries to match the queue failure itself instead of checking for lack of activity.

Please read Github PR Conventions and then fill in one of these two templates.

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions). Mergify only reads mergify.yml on master

The first one didn't fire, despite there being 3 PRs that should
have matched. This one tries to match the queue failure itself
instead of checking for lack of activity.
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it!

@geekosaur
Copy link
Collaborator Author

Not sure it's necessary at this point; the first one actually works, it just needs its wait time cranked down a bit (it's 5 days currently).

@ulysses4ever
Copy link
Collaborator

ulysses4ever commented Jan 11, 2025

5 days isn't bad! But in any case it'd be good to either merge or close!

@geekosaur
Copy link
Collaborator Author

I vote for closing, since the first one is actually working so there's no point in trying the somewhat dubious second.

@ulysses4ever
Copy link
Collaborator

SGTM, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants