Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for 3.14.1.1 #10675

Open
wants to merge 1 commit into
base: 3.14
Choose a base branch
from

Conversation

Kleidukos
Copy link
Member

Please read Github PR Conventions and then fill in one of these two templates.


Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:


Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@Kleidukos Kleidukos requested a review from geekosaur December 26, 2024 11:39
@ulysses4ever
Copy link
Collaborator

ulysses4ever commented Dec 26, 2024

Hey @Kleidukos! I don't know what the plan for 3.14.1.1 is but I think it would be good to include the "GHC 9.12 compat" commits from #10667

@geekosaur
Copy link
Collaborator

My own inclination is that I don't think that's strictly needed because this isn't intended for CI; but it would probably be good to silence any warnings. (I also am increasingly wondering why the GHC folks didn't warn us about any of this, specifically including the version warning that triggered this release.)

BTW, I'm getting the strong impression that "release manager" just got handed to me, despite my being on the "doing" end instead of the "managing" end (per Mikołaj). So I'm still a bit confused about whether it's @Kleidukos or me that has to sign off on it.

@Kleidukos
Copy link
Member Author

@ulysses4ever if you're complaining that your PR's changelog entry hasn't been included, please open a ticket in changelog-d's tracker.

@geekosaur
Copy link
Collaborator

No, it's not on 3.14.1.1 at all currently. (Or 3.14, for that matter.) He wants it backported.

@Kleidukos
Copy link
Member Author

Ah, that makes much more sense. Sure yeah!

@geekosaur
Copy link
Collaborator

Anyway: I think we need to get this out the door as quickly as possible, and in particular get it into ghcup before people get back from winter break. I've already turned off the new branch protection rule rather than backport my 3(!) PRs needed to make it work, because it's not worth fixing CI to make sdist checking happy when it's irrelevant to anything but a future full release. Same would go for the prerelease PRs, since neither 3.14 nor 3.14.1.1 is subject to them. Please, let's keep this minimal.

@geekosaur
Copy link
Collaborator

Actually, the more I think about it, the bigger problem is that the unix fix is the wrong one. It'll work for releases, but not for people installing from Hackage because that doesn't involve cabal.release.project and may therefore install the buggy unix. This specifically includes ghcup, which was what revealed the unix bug in the first place. Do we need to patch the cabal file instead?

@Kleidukos
Copy link
Member Author

@geekosaur yes I think it would be best.

@ulysses4ever
Copy link
Collaborator

installing from Hackage because that doesn't involve cabal.release.project and may therefore install the buggy unix

Good point

@Kleidukos Kleidukos added the merge me Tell Mergify Bot to merge label Dec 27, 2024
@Mikolaj Mikolaj force-pushed the 3.14.1.1-changelogs branch from 21c7be4 to 4c8ee90 Compare December 27, 2024 11:32
@Kleidukos Kleidukos removed the merge me Tell Mergify Bot to merge label Dec 27, 2024
Copy link
Contributor

mergify bot commented Dec 27, 2024

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #10675 has been dequeued. The pull request rule doesn't match anymore. The following conditions don't match anymore:

  • label=merge me
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = Doctest Cabal
        • check-skipped = Doctest Cabal
        • check-success = Doctest Cabal
      • any of: [🛡 GitHub branch protection]
        • check-neutral = Meta checks
        • check-skipped = Meta checks
        • check-success = Meta checks
      • any of: [🛡 GitHub branch protection]
        • check-neutral = Validate post job
        • check-skipped = Validate post job
        • check-success = Validate post job
      • any of: [🛡 GitHub branch protection]
        • check-neutral = Bootstrap post job
        • check-skipped = Bootstrap post job
        • check-success = Bootstrap post job

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants