-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog for 3.14.1.1 #10675
base: 3.14
Are you sure you want to change the base?
Changelog for 3.14.1.1 #10675
Conversation
Hey @Kleidukos! I don't know what the plan for 3.14.1.1 is but I think it would be good to include the "GHC 9.12 compat" commits from #10667 |
My own inclination is that I don't think that's strictly needed because this isn't intended for CI; but it would probably be good to silence any warnings. (I also am increasingly wondering why the GHC folks didn't warn us about any of this, specifically including the version warning that triggered this release.) BTW, I'm getting the strong impression that "release manager" just got handed to me, despite my being on the "doing" end instead of the "managing" end (per Mikołaj). So I'm still a bit confused about whether it's @Kleidukos or me that has to sign off on it. |
@ulysses4ever if you're complaining that your PR's changelog entry hasn't been included, please open a ticket in |
No, it's not on |
Ah, that makes much more sense. Sure yeah! |
Anyway: I think we need to get this out the door as quickly as possible, and in particular get it into ghcup before people get back from winter break. I've already turned off the new branch protection rule rather than backport my 3(!) PRs needed to make it work, because it's not worth fixing CI to make sdist checking happy when it's irrelevant to anything but a future full release. Same would go for the prerelease PRs, since neither |
Actually, the more I think about it, the bigger problem is that the |
@geekosaur yes I think it would be best. |
Good point |
21c7be4
to
4c8ee90
Compare
This pull request has been removed from the queue for the following reason: Pull request #10675 has been dequeued. The pull request rule doesn't match anymore. The following conditions don't match anymore:
You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
4c8ee90
to
fcd9aa0
Compare
Please read Github PR Conventions and then fill in one of these two templates.
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significant
in the changelog file.Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: