-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for GHC 7.4 #3833
Drop support for GHC 7.4 #3833
Conversation
GHC 7.4 is more than four years old now, well outside our three-year support window. (Actually, GHC 7.6 is outside our support window too, but I don't have any pending patches which are broken with that version.)
Sure, if it's blocking your work, then it's okay. But please add a changelog note. |
Actually, I just thought of a way around this. False alarm! |
It turns out there is a separate issue with GHC < 7.6 blocking my patch, so I'm reopening this. 😄 |
@@ -1,7 +1,7 @@ | |||
-*-change-log-*- | |||
|
|||
1.25.x.x (current development version) | |||
* Dropped support for versions of GHC earlier than 6.12 (#3111). | |||
* Dropped support for versions of GHC earlier than 7.6 (#3833). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#3111 was a bit different from this PR, I'd add a separate line saying "Cabal/cabal-install can no longer be compiled with GHC < 7.6" instead. Otherwise it should be possible to use 2.0 with 7.4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
wait a minute... why exactly are we dropping GHC 7.4 support? We need @ttuegel Can we revert this please? |
Cabal still works with GHC >= 7, you'll just need a newer GHC to build it. This is fine; Cabal can be built with a different version of GHC than it is building your package with. This is also in line with our GHC support window policy. |
I'm not talking about So is there are real blocker that you need to drop support for GHC 7.4? |
To be fair, our GHC window policy (which I wrote) specifies three versions for GHC, and more on a best effort basis. So we should change our window policy. |
Yes, I was being specific about punctuation.
The stated policy has always been:
If we need to reconsider this policy, please open a new issue. This discussion is not relevant to this PR, which complies with the stated policy. (Actually, this PR is more generous, as GHC 7.6 is also more than three years old.) |
There may be a good argument now for us reconsidering and expanding our support window. With the advent of setup-deps we can have a packages that need older versions of Cabal, and conversely using a new cabal-install with an older ghc may sill involve using packages that require a more recent Cabal. So we may have to expand our support window in both directions: point releases of older Cabal to work with newer ghc, and keeping latest Cabal building with older ghc. |
New ticket #3838. |
GHC 7.4 is more than four years old now, well outside our three-year
support window. (Actually, GHC 7.6 is outside our support window too,
but I don't have any pending patches which are broken with that
version.)
Attn. @23Skidoo @rthomas