Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicated modules for *Dependency types and UnqualComponentName #4107

Merged
merged 2 commits into from
Nov 14, 2016

Conversation

Ericson2314
Copy link
Collaborator

Also gets rid of Distribution.Packages.TextClass

@mention-bot
Copy link

@Ericson2314, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dcoutts, @grayjay and @hvr to be potential reviewers.

@Ericson2314 Ericson2314 force-pushed the dependency branch 4 times, most recently from b44cade to 1814501 Compare November 14, 2016 06:01
Also gets rid of `Distribution.Packages.TextClass`
...into Distribution.Utils.Generic. Distribution.Simple.Utils moved items.
@Ericson2314
Copy link
Collaborator Author

Ericson2314 commented Nov 14, 2016

So AppVeyor worked every time but this, and the failure is upstream, so either upstream needs to be fixed or we need to tighten a bound--both of which are orthogonal to this.
I feel bad about merging with a red light, but this is big and can bit-rot quick so gonna merge anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants