Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass -Wmissing-home-modules to all component types #4534

Merged
merged 1 commit into from
May 23, 2017

Conversation

hvr
Copy link
Member

@hvr hvr commented May 23, 2017

i.e. not only library components, but also executables, tests and benchmarks.

(With GHC-8.2.1 snapshot 8.2.0.20170521 or earlier, this emits a harmless warning about Main;
the next upcoming snapshot build of GHC-8.2.1 will already omit the spurious warning)

This addresses the other half of #4528

@mention-bot
Copy link

@hvr, thanks for your PR! By analyzing the history of the files in this pull request, we identified @luite, @ezyang and @dcoutts to be potential reviewers.

@hvr
Copy link
Member Author

hvr commented May 23, 2017

The PPA snapshot ghc-8.2.1_8.2.0.20170522+git.0.c0b82c3 which includes the upstream fix ghc/ghc@72eade6 is already building; give it about 2-3 hours to become available to Travis.

/cc @23Skidoo

i.e. not only library components, but also executables,
tests and benchmarks.

This addresses the other half of haskell#4528
@hvr hvr force-pushed the pr/issue-4528b branch from a7244d5 to 68a5925 Compare May 23, 2017 08:36
@23Skidoo
Copy link
Member

Travis is green. Do we need a test case?

@hvr
Copy link
Member Author

hvr commented May 23, 2017

@23Skidoo Well, at some point yes; I can think of a couple of constellations we could make into a testcase. However, This is all blocked on #4529 ...

So I'd just merge this one, and maybe create a reminder ticket to write testcases after GHC 8.2.1 got added to the test-matrix.

@23Skidoo 23Skidoo merged commit 27f8d3c into haskell:master May 23, 2017
@23Skidoo
Copy link
Member

Merged, thanks!

@23Skidoo
Copy link
Member

Also cherry-picked into 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants