Fix test suite wobbliness on GHC 8.2. #4554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here were the root causes: - Some tests involving Custom setpu showed MORE output (UseLocalPackageForSetup) when run on GHC 8.2. This is because GHC 8.2 ships a recent enough version of Cabal to know how to emit markers, which means we have started picking up the output. I hacked up these tests to not accept this output, but a more correct thing to do is figure out how to NOT request marking of a Setup script which is not the inplace install. This was a little tricky so I bailed. - GHC 8.2 no longer emits "It is a member of the hidden package". This broke CustomWithoutCabalDefaultMain. Not sure if this is a GHC regression but it's pretty harmless. - While I was at it, I fixed an inexhaustive pattern match in cabal-testsuite (though perhaps poorly; I couldn't figure out what the new constructor does.) Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
|
@ezyang, thanks for your PR! By analyzing the history of the files in this pull request, we identified @grayjay to be a potential reviewer. |
|
It looks like there is still one remaining failure, see #4529 (comment). |
|
#4529 has passed, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here were the root causes:
Some tests involving Custom setpu showed MORE output
(UseLocalPackageForSetup) when run on GHC 8.2. This is because GHC
8.2 ships a recent enough version of Cabal to know how to emit
markers, which means we have started picking up the output. I hacked
up these tests to not accept this output, but a more correct thing to
do is figure out how to NOT request marking of a Setup script which is
not the inplace install. This was a little tricky so I bailed.
GHC 8.2 no longer emits "It is a member of the hidden package".
This broke CustomWithoutCabalDefaultMain. Not sure if this
is a GHC regression but it's pretty harmless.
While I was at it, I fixed an inexhaustive pattern match in
cabal-testsuite (though perhaps poorly; I couldn't figure out
what the new constructor does.)
Signed-off-by: Edward Z. Yang ezyang@cs.stanford.edu
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!