-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add licenseIdMigrationMessages. Resolves #5109. #5113
Conversation
boot/SPDX.LicenseId.template.hs
Outdated
go "BSD2" = "Do you mean BSD-2-Clause?" | ||
go "AllRightsReserved" = "You can use NONE as a value of license field." | ||
go "OtherLicense" = "SPDX license list contains plenty of licenses. See https://spdx.org/licenses/. Also they can be combined into complex expressions with AND and OR." | ||
go "PublicDomain" = "Public Domain is a complex matter. See https://wiki.spdx.org/view/Legal_Team/Decisions/Dealing_with_Public_Domain_within_SPDX_Files. Consider using proper license." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the indefinite article: "Consider using a proper license." :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's good idea!
d808c07
to
1784094
Compare
1784094
to
797250a
Compare
For the record,
is what you'd write. (In my jurisdiction even I write so, I'll still retain copyright!) https://en.wikipedia.org/wiki/Comparison_of_free_and_open-source_software_licenses#Approvals
|
I'm not sure what happens on travis
|
@phadej I keep seeing that as well. Initially I thought I'd blame the basedir patch (#4874), but as that hasn't been merged yet. I'm also a bit confused. What apparently happens is that there However, while I occationally can reproduce this locally, when I try to run it verbosely ( |
PS: restarting travis jobs might help (and will eventually turn green...) |
Please include the following checklist in your PR:
[ci skip]
is used to avoid triggering the build bots.Please also shortly describe how you tested your change. Bonus points for added tests!