Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add licenseIdMigrationMessages. Resolves #5109. #5113

Merged
merged 1 commit into from
Feb 6, 2018

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Feb 5, 2018

Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

go "BSD2" = "Do you mean BSD-2-Clause?"
go "AllRightsReserved" = "You can use NONE as a value of license field."
go "OtherLicense" = "SPDX license list contains plenty of licenses. See https://spdx.org/licenses/. Also they can be combined into complex expressions with AND and OR."
go "PublicDomain" = "Public Domain is a complex matter. See https://wiki.spdx.org/view/Legal_Team/Decisions/Dealing_with_Public_Domain_within_SPDX_Files. Consider using proper license."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the indefinite article: "Consider using a proper license." :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good idea!

@phadej phadej force-pushed the spdx-migration-messages branch from d808c07 to 1784094 Compare February 5, 2018 09:20
@phadej phadej force-pushed the spdx-migration-messages branch from 1784094 to 797250a Compare February 5, 2018 09:22
@phadej
Copy link
Collaborator Author

phadej commented Feb 5, 2018

For the record, PublicDomain is hard, but my IANAL-understanding:

copyright: Public Domain
license: CC0

is what you'd write. (In my jurisdiction even I write so, I'll still retain copyright!)

https://en.wikipedia.org/wiki/Comparison_of_free_and_open-source_software_licenses#Approvals

  • CC0 isn't approved or rejected by OSI, Recommended by FSF (If you want to release your work to the public domain, we recommend you use CC0.: https://www.gnu.org/licenses/license-list.en.html#CC0)
  • Unlicense has partial approval by OSI: while considered free not recommended
  • Both are FSF approved and compatible with GPL-3.0

@phadej
Copy link
Collaborator Author

phadej commented Feb 6, 2018

I'm not sure what happens on travis

/home/travis/build/haskell/cabal/dist-newstyle/src/pretty-show-1.6.16/dist: renamePath:rename: unsatisfied constraints (Directory not empty)Configuring library for pretty-show-1.6.16.

@angerman
Copy link
Collaborator

angerman commented Feb 6, 2018

@phadej I keep seeing that as well. Initially I thought I'd blame the basedir patch (#4874), but as that hasn't been merged yet. I'm also a bit confused.

What apparently happens is that there Pretty.Text.Parser module (generated by alex/happy I believe) ends up in pretty-show/dist/build, and for some reason, cabal tries to rename the dist part (it's in cabal-installs Install.hs I believe). Not sure why we try to rename it. But that somehow trips up in System.Directory and ends up throwing a Directory not Empty exception.

However, while I occationally can reproduce this locally, when I try to run it verbosely (-v), it doesn't happen.

@angerman
Copy link
Collaborator

angerman commented Feb 6, 2018

PS: restarting travis jobs might help (and will eventually turn green...)

@phadej phadej merged commit 94a7374 into haskell:master Feb 6, 2018
@phadej phadej deleted the spdx-migration-messages branch February 6, 2018 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants