Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert " Rerun dependency solver to generate a better error message (issue #4823)." #5129

Closed
wants to merge 1 commit into from
Closed

Revert " Rerun dependency solver to generate a better error message (issue #4823)." #5129

wants to merge 1 commit into from
+158 −308

Conversation

23Skidoo
Copy link
Member

@23Skidoo 23Skidoo commented Feb 8, 2018

Reverts #5012

@phadej
Copy link
Collaborator

phadej commented Feb 8, 2018

Commit message should say why we do this revert.

ping @grayjay

@23Skidoo
Copy link
Member Author

23Skidoo commented Feb 8, 2018

@phadej Will do. See my comment in #5012 for now.

@23Skidoo
Copy link
Member Author

23Skidoo commented Feb 8, 2018

OK, this unborks AppVeyor at least...

@grayjay
Copy link
Collaborator

grayjay commented Feb 9, 2018

I'm looking into the failure now. I think it's a test-only issue.

@grayjay
Copy link
Collaborator

grayjay commented Feb 10, 2018

#5133 fixed the test failure.

@23Skidoo 23Skidoo closed this Feb 10, 2018
@23Skidoo 23Skidoo deleted the revert-5012-issue-4823 branch February 10, 2018 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@23Skidoo @phadej @grayjay