-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cabal get --only-package-description
#5162
Conversation
With this option, 'cabal get' writes to the destination directory only the package description already available locally in one of the repository indices. The basename of the file name written to inside the target directory is the package-id rather than only the package name. This is mostly based on haskell#1977 Co-authored-by: Miëtek Bak <mietek@bak.io>
Looks all right on a first glance, but needs docs; this is the relevant manual section: https://cabal.readthedocs.io/en/latest/developing-packages.html#downloading-a-package-s-source |
@23Skidoo just asking for the changelog-entry, is this 2.2 material or post-2.2 ? |
I think it's low risk, we can merge it into 2.2. |
if this is still sensible I think pristine should be already working (I hope so, don't checked it) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a changelog entry and updating docs but the code looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops
Closing in favour of #8263, thanks all! |
With this option, 'cabal get' writes to the destination directory only the
package description already available locally in one of the repository
indices.
The basename of the file name written to inside the target directory is
the package-id rather than only the package name.
This is mostly based on #1977
Co-authored-by: Miëtek Bak mietek@bak.io
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!