Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.2, DO NOT MERGE] Revert "Merge pull request #4874 from zw3rk/feature/basedir" #5179

Closed
wants to merge 1 commit into from

Conversation

23Skidoo
Copy link
Member

@23Skidoo 23Skidoo commented Mar 2, 2018

This reverts commit 783cbe6, reversing changes made to c094940.

The basedir patch breaks GHC (see #5075 (comment)), so unless that issue gets fixed soon (@alpmestan, @angerman and @hvr are looking into it) we'll have to revert it on the 2.2 branch to unblock the 8.4.1 release.


Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

This reverts commit 783cbe6, reversing
changes made to c094940.
@23Skidoo 23Skidoo added this to the 2.2 milestone Mar 2, 2018
@23Skidoo
Copy link
Member Author

23Skidoo commented Mar 2, 2018

/cc @bgamari

@23Skidoo
Copy link
Member Author

23Skidoo commented Mar 2, 2018

To make it clear: this is plan B in case plan A (merging https://phabricator.haskell.org/D4453) doesn't work.

@angerman
Copy link
Collaborator

angerman commented Mar 3, 2018

Current phabricator CI status:

  • Windows: OK
  • Linux: Waiting to build.
  • macOS: some ext-int failures (which I can not locally reproduce on my mac...)

@hvr
Copy link
Member

hvr commented Mar 3, 2018

macOS: some ext-int failures (which I can not locally reproduce on my mac...)

those seem completely orthogonal to the basedir patch; what I've figured out so far is that -fexternal-interpreter indeterministically segfaults... for no apparent reason; I had to invoke ghc-stage2 in a loop for couple dozen times before it would segfault.

I expect Linux to validate just as it did before my trivial fixup/hack was applied.

@23Skidoo
Copy link
Member Author

23Skidoo commented Mar 5, 2018

I see that D4453 has been merged, so looks like we won't need this. Closing.

@23Skidoo 23Skidoo closed this Mar 5, 2018
@23Skidoo 23Skidoo deleted the 2.2-revert-basedir branch March 5, 2018 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants