Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EmptyDataDeriving as an Extension constructor. #6015

Merged

Conversation

quasicomputational
Copy link
Contributor

This was added in GHC 8.4 but apparently either no-one's missed its
absence since then, or users have been suffering in silence with the
warnings.


Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

This was added in GHC 8.4 but apparently either no-one's missed its
absence since then, or users have been suffering in silence with the
warnings.
@quasicomputational quasicomputational added this to the 3.0 milestone Apr 26, 2019
@23Skidoo
Copy link
Member

Great, just in time for 3.0.

@quasicomputational
Copy link
Contributor Author

Yep - total luck that I bumped into this so soon before the 3.0 release.

Copy link
Member

@23Skidoo 23Skidoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge once it's green.

@23Skidoo 23Skidoo merged commit 6316102 into haskell:master Apr 26, 2019
@23Skidoo
Copy link
Member

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants