Use lukko for file-locking #6345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wonder what causes that.
#define _GNU_SOURCE
#include <unistd.h>
#include <fcntl.h>so EDIT: oh, dear, we run travis on trusty, which has kernels 3.13..3.19, ofd is 3.15+ (and I'm not sure which glibc had definitions). https://wiki.ubuntu.com/Kernel/Support |
This was referenced Dec 3, 2019
Closed
|
What's the advantage over previous solution? |
|
@arybczak are there some problems? The reasons was to reduce the code duplication in |
|
No, I was just curious because I wrote the original locking code ;) |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Apr 25, 2021
3.4.0.0 Oleg Grenrus <oleg.grenrus@iki.fi> February 2021 * See https://github.com/haskell/cabal/blob/master/release-notes/cabal-install-3.4.0.0.md 3.2.0.0 Herbert Valerio Riedel <hvr@gnu.org> April 2020 * `v2-build` (and other `v2-`prefixed commands) now accept the `--benchmark-option(s)` flags, which pass options to benchmark executables (analogous to how `--test-option(s)` works). (#6209) * Add solver optimization to skip a version of a package if it does not resolve any conflicts encountered in the last version, controlled by flag '--fine-grained-conflicts'. (#5918) * `cabal v2-exec` doesn't fail in clean package (#6479) * Show full ABI hash for installed packages in solver log (#5892) * Create incoming directory even for empty packages (#4130) * Start GHCi with `main-is` module in scope (#6311) * Implement `--benchmark-options` for `v2-bench` (#6224) * Fix store-dir in ghc env files generated by `cabal install --lib --package-env` (#6298) * `cabal v2-run` works with `.lhs` files (#6134) * `subdir` in source-repository-package accepts multiple entries (#5472) 3.0.1.0 Herbert Valerio Riedel <hvr@gnu.org> April 2020 * Create store incoming directory ([#4130](haskell/cabal#4130)) * `fetchRepoTarball` output is not marked ([#6385](haskell/cabal#6385)) * Update `setupMinCabalVersionConstraint` for GHC-8.8 ([#6217](haskell/cabal#6217)) * Implement `cabal install --ignore-project` ([#5919](haskell/cabal#5919)) * `cabal install executable` solver isn't affected by default environment contents ([#6410](haskell/cabal#6410)) * Use `lukko` for file locking ([#6345](haskell/cabal#6345)) * Use `hackage-security-0.6` ([#6388](haskell/cabal#6388)) * Other dependency upgrades
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please include the following checklist in your PR:
[ci skip]is used to avoid triggering the build bots.Please also shortly describe how you tested your change. Bonus points for added tests!