Remove AnyVersion and WildcardVersion constructors #6742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
phadej
force-pushed
the
any-version
branch
3 times, most recently
from
42efb51 to
99efcb4
Compare
phadej
changed the title
These constructors don't carry any additional semantics. They were used in `cabal check` implementation, but now already parser reports errors so we don't need these redundant constructors anymore. MajorBoundVersion (^>=) has slightly different semantics: we want be able to relax only `^>= x.y.z` upper bounds. Therefore it's preserved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
roundtrip doesn't pass yet, as
parsec < 3 || >= 3normalises to justparsec.