Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weeder #6779

Merged
merged 1 commit into from
May 11, 2020
Merged

Add weeder #6779

merged 1 commit into from
May 11, 2020

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented May 11, 2020

make weeder

to run weeder.

There are plenty of false positives. But still, useful. Thanks @ocharles for the tool.

@ocharles
Copy link
Contributor

How exciting! If you didn't know, you can add those false positives to your Weeder config. I'd also be interested to know which of those are not truly dead, as those would be bugs in Weeder. Sounds like I can grab this branch and have a play myself to get that, though. Maybe a ZuriHac project!

@phadej
Copy link
Collaborator Author

phadej commented May 11, 2020

Some stuff is used in tests, or is there just for completeness.

@phadej phadej merged commit 6736cc2 into haskell:master May 11, 2020
@phadej phadej deleted the weeder branch May 11, 2020 19:17
@ocharles
Copy link
Contributor

Weeder should pick all test uses up as test suites produce a Main.main root (but you need to build tests with hie files, of course)

@phadej
Copy link
Collaborator Author

phadej commented May 12, 2020

Can one list everything on hackage-security as root? (It's a local library, as it depends on Cabal, so it's is built).

@ocharles
Copy link
Contributor

Currently a root is a regular expression matching symbol names, and that only mentions module names and variable names at the moment. Perhaps everything there is under a common module prefix? E.g., would ^Hackage.Security..* work?

@phadej phadej added this to the 3.4.0.0-rc1 milestone Jul 10, 2020
@phadej phadej mentioned this pull request Jul 10, 2020
@philderbeast philderbeast mentioned this pull request Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants