Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6807 listbin #6931

Merged
merged 2 commits into from
Jul 1, 2020
Merged

Issue 6807 listbin #6931

merged 2 commits into from
Jul 1, 2020

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Jun 29, 2020

Partially resolves #6807

I need to test this on Windows and with GHCJS

Also output extension for executables.
@phadej phadej added this to the 3.4.0.0 milestone Jun 29, 2020
@phadej phadej force-pushed the issue-6807-listbin branch 2 times, most recently from 34950bb to 819e85a Compare June 30, 2020 17:26
This is partial solution to haskell#6807, because we invoke solver.
The follow-up will be to modify Rebuild monad so,
that it can be run without rebuilding (i.e. fail if cache is cold).
@phadej phadej force-pushed the issue-6807-listbin branch from 819e85a to 17e5e07 Compare June 30, 2020 18:06
@phadej
Copy link
Collaborator Author

phadej commented Jul 1, 2020

This also fixes Windows issue where plan.json didn't have executable extension:

PS C:\Users\Oleg Grenrus\Documents\cabal-plan> cabal run cabal-plan list-bins
Linking C:\Users\Oleg Grenrus\Documents\cabal-plan\dist-newstyle\build\x86_64-windows\ghc-8.6.5\cabal-plan-0.7.0.0\x\cabal-plan\build\cabal-plan\cabal-plan.exe ...
cabal-plan:exe:cabal-plan  C:\Users\Oleg Grenrus\Documents\cabal-plan\dist-newstyle\build\x86_64-windows\ghc-8.6.5\cabal-plan-0.7.0.0\x\cabal-plan\build\cabal-plan\cabal-plan
PS C:\Users\Oleg Grenrus\Documents\cabal-plan> & '...\cabal-install-3.3.0.0\x\cabal\build\cabal\cabal.exe' run cabal-plan list-bins
Up to date
cabal-plan:exe:cabal-plan  C:\Users\Oleg Grenrus\Documents\cabal-plan\dist-newstyle\build\x86_64-windows\ghc-8.6.5\cabal-plan-0.7.0.0\x\cabal-plan\build\cabal-plan\cabal-plan.exe

But AFAICS it will also add jsexe to GHCJS executables, which may or may not break some scripts when cabal-install is updated to 3.4. Missing .jsexe was a bug, not a feature.

@phadej phadej merged commit 5274d6a into haskell:master Jul 1, 2020
@phadej phadej deleted the issue-6807-listbin branch July 1, 2020 15:39
@phadej phadej mentioned this pull request Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cabal list-bin
1 participant