Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove coverage from main cabal.project, add to dedicated file #7421

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

emilypi
Copy link
Member

@emilypi emilypi commented Jun 1, 2021

This PR addresses #7384 by deliberately keeping the project coverage details encapsulated in a dedicated .project file so the main build will not result in .tix file litter.

@Mikolaj Mikolaj self-requested a review June 2, 2021 00:57
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we currently do coverage in CI? If so, should we now refer to the new project file via commandline options?

@ezyang
Copy link
Contributor

ezyang commented Jun 2, 2021

Thanks, this was bugging me!

@emilypi
Copy link
Member Author

emilypi commented Jun 2, 2021

@Mikolaj we don't, but if we did, this would be the correct preparatory step for that work. You can call it directly with cabal build --project-file cabal.project.coverage <target>.

@emilypi emilypi force-pushed the fix/remove-coverage-in-project-file branch from 317559e to 0f6ce1b Compare June 2, 2021 16:28
Copy link
Member

@fgaz fgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fgaz fgaz merged commit bd713cd into master Jun 2, 2021
@fgaz fgaz deleted the fix/remove-coverage-in-project-file branch June 2, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants