Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude CI job 8.10.7 on Windows that corrupts all CI #8388

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Exclude CI job 8.10.7 on Windows that corrupts all CI #8388

merged 2 commits into from
Aug 16, 2022

Conversation

Mikolaj
Copy link
Member

@Mikolaj Mikolaj commented Aug 16, 2022 •
edited
Loading

See #8356 and #8385.

@Mikolaj
Copy link
Member Author

Mikolaj commented Aug 16, 2022

The symptoms are so strange and mysterious, that this is at best a workaround of #8356. It would be great to get to the bottom of it, but OTOH CI needs to mostly work or dev is stalled and we accumulate bugs.

@Mikolaj
Copy link
Member Author

Mikolaj commented Aug 16, 2022

CI passes after disabling 8.10.7 on Windows. @jneira: you might have had a good hunch that was the culprit.

Now let me try to disable the previous workaround, contained in #8357.

@Mikolaj
Revert "Turn off DeterministicTrivial test (see haskell#8356)"
c68ed01 
This reverts commit cd7a912.

It's not needed any more, probably, because another workaround
fixes CI differently, probably. As long as it's deterministic enough...
@Mikolaj Mikolaj marked this pull request as ready for review August 16, 2022 13:45
This was referenced Aug 16, 2022
Closed
Closed
@Mikolaj
Copy link
Member Author

Mikolaj commented Aug 16, 2022

@mergify backport 3.8

@Mikolaj
Copy link
Member Author

Mikolaj commented Aug 16, 2022

Emergency-merging before the 2-day period elapses.

@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2022 •
edited
Loading

backport 3.8

✅ Backports have been created

@Mikolaj
Copy link
Member Author

Mikolaj commented Aug 16, 2022

@mergify rebase

@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2022

rebase

☑️ Nothing to do

  • -closed [:pushpin: rebase requirement]
  • any of:
    • #commits-behind>0 [:pushpin: rebase requirement]
    • -linear-history [:pushpin: rebase requirement]

@Mikolaj Mikolaj merged commit 1b6a524 into haskell:master Aug 16, 2022
@mergify mergify bot mentioned this pull request Aug 16, 2022
Merged
jneira
jneira reviewed Aug 16, 2022
View reviewed changes
.github/workflows/validate.yml
@@ -40,6 +40,9 @@ jobs:
os: ["ubuntu-latest", "macos-latest", "windows-latest"]
ghc: ["9.2.3", "9.0.2", "8.10.7", "8.8.4", "8.6.5", "8.4.4"]
exclude:
# corrupts GHA cache or the fabric of reality itself, see https://github.com/haskell/cabal/issues/8356
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

@jneira
Copy link
Member

jneira commented Aug 16, 2022 •
edited
Loading

hmm that is unfortunate, 8.10.7 is and will be a very stable version, i think it will be the succesor of 8.6.5
but i understand it should be done temporary (i hope!)

Mikolaj added a commit that referenced this pull request Aug 16, 2022
@Mikolaj
Merge pull request #8389 from haskell/mergify/bp/3.8/pr-8388
9d7fea1 
Exclude CI job 8.10.7 on Windows that corrupts all CI (backport #8388)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira left review comments

@ffaf1 ffaf1 ffaf1 approved these changes

@ulysses4ever ulysses4ever ulysses4ever approved these changes

Assignees
No one assigned
Labels
attention: needs-review continuous-integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mikolaj @jneira @ulysses4ever @ffaf1