Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document internal library syntax changes #8573

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Conversation

chowells79
Copy link
Contributor

As of cabal-version: 3.4 and higher, it's necessary to use a different syntax to depend on internal libraries than previous versions. Document this change in a note block in the Internal Libraries section.

See: #7565


Please include the following checklist in your PR:

Please also shortly describe how you tested your change. Bonus points for added tests!

@Mikolaj
Copy link
Member

Mikolaj commented Nov 7, 2022

There seem to be a CI hiccup. Let me restart CI...

@Mikolaj
Copy link
Member

Mikolaj commented Nov 7, 2022

Let me restart once again, for science.

@Mikolaj
Copy link
Member

Mikolaj commented Nov 7, 2022

Let me rebase and, let's hope, CI should be fixed at that point.

@Mikolaj
Copy link
Member

Mikolaj commented Nov 7, 2022

@mergify rebase

As of cabal-version: 3.4 and higher, it's necessary to use a different
syntax to depend on internal libraries than previous versions. Document
this change in a note block in the Internal Libraries section.

See: haskell#7565
@mergify
Copy link
Contributor

mergify bot commented Nov 7, 2022

rebase

✅ Branch has been successfully rebased

Copy link
Member

@fgaz fgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a worthwhile note, I'm falling for that one myself. Thank you.

@Mikolaj
Copy link
Member

Mikolaj commented Nov 7, 2022

CI seems to be going on fine, so let me take the liberty of setting the merge_me label to expedite this helpful PR.

@Mikolaj Mikolaj added the merge me Tell Mergify Bot to merge label Nov 7, 2022
@Mikolaj
Copy link
Member

Mikolaj commented Nov 7, 2022

2 days after any movement here, this PR should be auto-merged by mergify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants