Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cabal-testsuite #8401: communicate better the need for --with-cabal #8672

Merged
merged 3 commits into from
Jan 16, 2023
Merged

cabal-testsuite #8401: communicate better the need for --with-cabal #8672

merged 3 commits into from
Jan 16, 2023

Conversation

andreasabel
Copy link
Member

@andreasabel andreasabel commented Jan 13, 2023 •
edited
Loading

cabal-testsuite #8401: communicate better the need for --with-cabal

  • include option --help in cabal-testsuite (separate commit)
  • include warning in help text for option --with-cabal
  • include --with-cabal in README examples
  • passer-by: remove a CPP-avoidance hack (separate commit)

N.B. Separate commits, no squashing please!

@andreasabel andreasabel added attention: needs-review cabal-testsuite re: devx Improving the cabal developer experience (internal issue) labels Jan 13, 2023
@andreasabel andreasabel self-assigned this Jan 13, 2023
Mikolaj
Mikolaj approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's very helpful.

cabal-testsuite/main/cabal-tests.hs Show resolved Hide resolved
@andreasabel andreasabel force-pushed the issue-8401-cabal-tests-help branch from beae915 to 4eab1b7 Compare January 13, 2023 15:33
@andreasabel andreasabel added the merge me Tell Mergify Bot to merge label Jan 13, 2023
jneira
jneira approved these changes Jan 14, 2023
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks for make dev life easier

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Jan 16, 2023
@andreasabel @mergify
cabal-testsuite: replace Data.Monoid.<> hack to avoid unused-imports
2747dd4 
Rather than obfuscating by sprinkling in a fully qualified reference
to `<>` when unqualified references also work, limit the import of
`Data.Monoid.<>` with a suitable CPP.
@andreasabel @mergify
cabal-testsuite: add option --help
06c8fd5
@andreasabel @mergify
cabal-testsuite #8401: communicate better that --with-cabal is needed
a97cd47 
- Add caveat to `--help` text.
- Put `--with-cabal` into very first example in README.
@andreasabel andreasabel force-pushed the issue-8401-cabal-tests-help branch from 4eab1b7 to a97cd47 Compare January 16, 2023 12:50
@andreasabel
Copy link
Member Author

andreasabel commented Jan 16, 2023 •
edited
Loading

CI fails because of:

I restarted: https://github.com/haskell/cabal/actions/runs/3930539620

@mergify mergify bot merged commit 96dea0f into master Jan 16, 2023
@andreasabel andreasabel deleted the issue-8401-cabal-tests-help branch January 16, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

@Mikolaj Mikolaj Mikolaj approved these changes

@ulysses4ever ulysses4ever Awaiting requested review from ulysses4ever

@fgaz fgaz Awaiting requested review from fgaz

Assignees

@andreasabel andreasabel

Labels
attention: needs-review cabal-testsuite merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge re: devx Improving the cabal developer experience (internal issue)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreasabel @jneira @Mikolaj