Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: disable prerelease validation #8852

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Conversation

ulysses4ever
Copy link
Collaborator

@ulysses4ever ulysses4ever commented Mar 14, 2023

We have a transient failure there due to bumping our package version numbers (#8844): the cabal testsuite can't be configured (#8133 strikes again). So, let's disable it, get CI green and wait until version numbers are settled with the addition of the proper 9.6 release (#8840).

The job could be reenabled later in the future when a new GHC prerelease appears (9.8 family).

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mikolaj
Copy link
Member

Mikolaj commented Mar 14, 2023

Feel free to emergency-merge (set the delay-passed label).

@ulysses4ever ulysses4ever force-pushed the ci-disable-prerelease branch from 3349452 to 6fef8fd Compare March 14, 2023 19:08
@ulysses4ever ulysses4ever added attention: needs-review merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Mar 14, 2023
@ulysses4ever
Copy link
Collaborator Author

CI is green but this is missing one more approval. Given that this is a somewhat emergent fix to the CI, and having Mikolaj's blessing, I hereby fast-track the merge.

@ulysses4ever ulysses4ever merged commit e2dc1ea into master Mar 14, 2023
@ulysses4ever ulysses4ever deleted the ci-disable-prerelease branch March 14, 2023 21:52
@ulysses4ever ulysses4ever removed the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Mar 14, 2023
@Mikolaj
Copy link
Member

Mikolaj commented Mar 21, 2023

@mergify backport 3.10

@mergify
Copy link
Contributor

mergify bot commented Mar 21, 2023

backport 3.10

✅ Backports have been created

mergify bot added a commit that referenced this pull request Mar 21, 2023
CI: disable prerelease validation (backport #8852)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants