-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the extension ListTuplePuns (GHC proposal 475) #8854
add the extension ListTuplePuns (GHC proposal 475) #8854
Conversation
10ab83f
to
897f84c
Compare
Thanks for the contribution! CI fails in the usual place: you have to update that hash whenever add an extension. |
897f84c
to
be88a1b
Compare
This time it failed to a usual GHA outage, so I've restarted failed jobs. |
@tek: is this ready for merge? If so, could you rebase, remove the |
39b9a04
to
887adf3
Compare
the GHC MR is still not approved, though Vlad is pushing for it, so might be a few days. |
cf0aed3
to
4ed2547
Compare
ok I guess this doesn't have to wait for the GHC MR to be merged! |
@Mikolaj I have no label permissions, though |
How about now? |
thanks! |
4ed2547
to
98e0370
Compare
hey @Mikolaj, would you be so kind and merge this now? |
98e0370
to
72ceff7
Compare
Feel free to proceed with the labels, as described here: https://github.com/haskell/cabal/blob/master/CONTRIBUTING.md#github-pull-request-conventions |
@tek: apparently, a conflict with the master branch popped up at the last moment. Once you resolve it, merging should resume (probably immediately, but at worst in 2 days). |
72ceff7
to
2d0d316
Compare
2d0d316
to
ea7f8af
Compare
Upcoming extension, see https://gitlab.haskell.org/ghc/ghc/-/merge_requests/8820