Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put back github actions cache restore #8881

Closed
wants to merge 1 commit into from

Conversation

ulysses4ever
Copy link
Collaborator

@ulysses4ever ulysses4ever commented Mar 29, 2023

The recent reordering was done in anger due to haskell/actions#203 but it has been fixed upstream. The current state is not correct because we say we cache the cabal-store that doesn't exist yet (because of the said reordering).

Undo 6bd17fc from #8844.

@ulysses4ever ulysses4ever requested a review from Mikolaj March 29, 2023 18:41
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So does this revert a part of a particular commit from a particular PR?

@ulysses4ever
Copy link
Collaborator Author

Right. It's 6bd17fc from #8844.

@ulysses4ever
Copy link
Collaborator Author

Actually, I think it's better to squeeze this change into #8840. I'll ask you, Mikolaj, to take a look at it again when it's ready for merge. Hopefully, this week...

@ulysses4ever ulysses4ever deleted the undo-github-cache-early-init branch April 21, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants