Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GHC 9.8 in cabal 3.10.2.0 #9225

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Support GHC 9.8 in cabal 3.10.2.0 #9225

merged 2 commits into from
Sep 5, 2023

Conversation

Kleidukos
Copy link
Member

GHC 9.8 support

@Kleidukos Kleidukos added the merge me Tell Mergify Bot to merge label Sep 1, 2023
@Kleidukos Kleidukos mentioned this pull request Sep 1, 2023
Closed
2 tasks
@Kleidukos Kleidukos requested a review from Mikolaj September 1, 2023 13:25
Mikolaj
Mikolaj requested changes Sep 1, 2023
View reviewed changes
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release checklist says "Update setupMinCabalVersionConstraint (in Distribution.Client.ProjectPlanning)" and git grep setupMinCabalVersionConstraint suggests this may indeed be needed (or just mildly helpful; I don't know how crucial this is).

@Kleidukos Kleidukos force-pushed the 3.10.2.0-support-ghc-9.8 branch from 6c9813b to 3f34bb5 Compare September 1, 2023 13:58
@Kleidukos Kleidukos requested a review from Mikolaj September 1, 2023 13:58
Mikolaj
Mikolaj approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.

@Kleidukos Kleidukos added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Sep 1, 2023
@Mikolaj
Copy link
Member

Mikolaj commented Sep 1, 2023

How the time flies...

bgamari
bgamari previously requested changes Sep 2, 2023
View reviewed changes
cabal-install/src/Distribution/Client/ProjectPlanning.hs Outdated Show resolved Hide resolved
@Kleidukos @bgamari
Update cabal-install/src/Distribution/Client/ProjectPlanning.hs
d896730 
Co-authored-by: Ben Gamari <ben@smart-cactus.org>
@Kleidukos Kleidukos removed merge me Tell Mergify Bot to merge merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Sep 3, 2023
@Kleidukos Kleidukos requested a review from bgamari September 3, 2023 07:34
@Kleidukos
Copy link
Member Author

@bgamari merging is blocked on your review :)

@Kleidukos Kleidukos changed the title Support GHC 9.8 Support GHC 9.8 in cabal 3.10.2.0 Sep 4, 2023
@Mikolaj Mikolaj dismissed bgamari’s stale review September 5, 2023 20:37

the changes are made, but ICFP got in the way :)

@Kleidukos Kleidukos added squash+merge me Tell Mergify Bot to squash-merge merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Sep 5, 2023
@Kleidukos Kleidukos merged commit 3b74b68 into haskell:3.10 Sep 5, 2023
@Kleidukos Kleidukos deleted the 3.10.2.0-support-ghc-9.8 branch September 5, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulysses4ever ulysses4ever ulysses4ever left review comments

@Mikolaj Mikolaj Mikolaj approved these changes

@ffaf1 ffaf1 ffaf1 approved these changes

@bgamari bgamari Awaiting requested review from bgamari

Assignees
No one assigned
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days squash+merge me Tell Mergify Bot to squash-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kleidukos @Mikolaj @bgamari @ulysses4ever @ffaf1